From owner-svn-src-head@freebsd.org Fri Oct 27 16:39:32 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7ED1CE4B967; Fri, 27 Oct 2017 16:39:32 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0F8D36F2D2; Fri, 27 Oct 2017 16:39:32 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-wm0-x236.google.com with SMTP id r196so4609087wmf.2; Fri, 27 Oct 2017 09:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EHd/ewZ+LXdF6awcA/aiLGdM0FJLxgFCNtQzd6LjDuI=; b=U/jPY0SkmHSDnLPdidUDRhXhJ3MsJDQoO2nPkOFsTAqzAkw6oLUsOKVpmGlAgmKyWr lJl8puYRim5I+u6hMhP19l8IFc1ACgvsAfaENj1LdGNdVOEK7MbpcdN9v+CwwWYVEDYw +1TeVh7tjMD1mbSczwbTFIzOcB68wlkyV4nmIc0r+iwr+dELUWNmHmK9VT3SGJT12nD/ zWB4pGQsTONz/PItCUoX66dTDUsqqx5IyhPZ/8piflw3e1jWn1+aCb9RuyVetyngmhCQ raNuyAPFNItnxK8TksaCBRxzxFjwjIB78M2ai93equteSL1mG8cBrJUhJv/UzPgvPanf PR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EHd/ewZ+LXdF6awcA/aiLGdM0FJLxgFCNtQzd6LjDuI=; b=g/vABSVsbW11/O/4MdlDR6RNjHJAec2QLYwIwunxZEGiMcGloVr2zcf46isc/u5AsI mhtroYixzZhcdzmyN3e7dSpSzmU43/uZrce1qNuLyt2KqkEKY88vcNGhi4aGnhghy0wo c3OGEAlVWTZyeK0Evaq5xA3ofiEyYdb5EqD+Gj10leiw3LAmPLUSlOf6ugCOSFkfneUe +8vptQFnrJL8TrWeh5dOKiZ12q9n1aIM99IMv09g3zRPEtZusa/YSzzAv9Q9p2sl4VxD vW4o+dxVQozeG5IrZ/6P9b6+xUyBosDWw8on+dCPijytBbCZv6mr/SNahr82TtBQthQg kSrQ== X-Gm-Message-State: AMCzsaUrSPT4sBF/IjZHF7/epxO2YI6hyR5IzGPL2fom5y7/+4EAY5JP xW51arOHEAP7CjFfbZoCuILBtINDwwg= X-Google-Smtp-Source: ABhQp+QXxqb6LclwSkKrxuNAtxcZisZiTEn3I9X7Ou0m4sI3JJMDHrdjCsX8uGNMn30nwzkcLlONKA== X-Received: by 10.80.177.41 with SMTP id k38mr1381523edd.41.1509122369628; Fri, 27 Oct 2017 09:39:29 -0700 (PDT) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id n20sm5750917edb.93.2017.10.27.09.39.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Oct 2017 09:39:29 -0700 (PDT) From: Michal Meloun X-Google-Original-From: Michal Meloun Reply-To: meloun.michal@gmail.com Subject: Re: svn commit: r325042 - head/cddl/contrib/opensolaris/lib/libdtrace/common To: Ed Maste , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201710271623.v9RGNjec047721@repo.freebsd.org> Message-ID: <5e94395e-9feb-0f17-db3b-43583c461242@gmail.com> Date: Fri, 27 Oct 2017 18:39:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201710271623.v9RGNjec047721@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Oct 2017 16:39:32 -0000 On 27.10.2017 18:23, Ed Maste wrote: > Author: emaste > Date: Fri Oct 27 16:23:45 2017 > New Revision: 325042 > URL: https://svnweb.freebsd.org/changeset/base/325042 > > Log: > libdtrace: replace "DOODAD" with more descriptive string > > Previously some unimplemented libdtrace routines printed the function, > file and line number, followed by "DOODAD." That is not particularly > informative, so replace it with a message reporting the actual issue. > > Sponsored by: The FreeBSD Foundation > > Modified: > head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c > head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_proc.c > Imho, assert would be much more appropriate. So far, and for affected arches, if port uses USDT probes then dtrace produces broken object files and it ends with exit code 0. This causes runaway build processes (on arm, unprocessed probe is compiled as branch to itself) see: http://beefy8.nyi.freebsd.org/data/head-armv6-default/p452566_s324810/logs/errors/erlang-runtime20-20.1.log Michal > Modified: head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c > ============================================================================== > --- head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c Fri Oct 27 15:33:26 2017 (r325041) > +++ head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_link.c Fri Oct 27 16:23:45 2017 (r325042) > @@ -229,10 +229,12 @@ prepare_elf32(dtrace_hdl_t *dtp, const dof_hdr_t *dof, > for (j = 0; j < nrel; j++) { > #if defined(__aarch64__) > /* XXX */ > -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__); > + printf("%s:%s(%d): aarch64 not implemented\n", > + __FUNCTION__, __FILE__, __LINE__); > #elif defined(__arm__) > /* XXX */ > -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__); > + printf("%s:%s(%d): arm not implemented\n", > + __FUNCTION__, __FILE__, __LINE__); > #elif defined(__i386) || defined(__amd64) > rel->r_offset = s->dofs_offset + > dofr[j].dofr_offset; > @@ -240,7 +242,8 @@ printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__L > R_386_PC32); > #elif defined(__mips__) > /* XXX */ > -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__); > + printf("%s:%s(%d): MIPS not implemented\n", > + __FUNCTION__, __FILE__, __LINE__); > #elif defined(__powerpc__) > /* > * Add 4 bytes to hit the low half of this 64-bit > @@ -252,7 +255,8 @@ printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__L > R_PPC_REL32); > #elif defined(__riscv) > /* XXX */ > -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__); > + printf("%s:%s(%d): RISC-V not implemented\n", > + __FUNCTION__, __FILE__, __LINE__); > #else > #error unknown ISA > #endif > @@ -802,7 +806,8 @@ static int > dt_modtext(dtrace_hdl_t *dtp, char *p, int isenabled, GElf_Rela *rela, > uint32_t *off) > { > -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__); > + printf("%s:%s(%d): aarch64 not implemented\n", __FUNCTION__, __FILE__, > + __LINE__); > return (0); > } > #elif defined(__arm__) > @@ -811,7 +816,8 @@ static int > dt_modtext(dtrace_hdl_t *dtp, char *p, int isenabled, GElf_Rela *rela, > uint32_t *off) > { > -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__); > + printf("%s:%s(%d): arm not implemented\n", __FUNCTION__, __FILE__, > + __LINE__); > return (0); > } > #elif defined(__mips__) > @@ -820,7 +826,8 @@ static int > dt_modtext(dtrace_hdl_t *dtp, char *p, int isenabled, GElf_Rela *rela, > uint32_t *off) > { > -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__); > + printf("%s:%s(%d): MIPS not implemented\n", __FUNCTION__, __FILE__, > + __LINE__); > return (0); > } > #elif defined(__powerpc__) > @@ -910,7 +917,8 @@ static int > dt_modtext(dtrace_hdl_t *dtp, char *p, int isenabled, GElf_Rela *rela, > uint32_t *off) > { > -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__); > + printf("%s:%s(%d): RISC-V implementation required\n", __FUNCTION__, > + __FILE__, __LINE__); > return (0); > } > #elif defined(__sparc) > > Modified: head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_proc.c > ============================================================================== > --- head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_proc.c Fri Oct 27 15:33:26 2017 (r325041) > +++ head/cddl/contrib/opensolaris/lib/libdtrace/common/dt_proc.c Fri Oct 27 16:23:45 2017 (r325042) > @@ -426,7 +426,8 @@ dt_proc_attach(dt_proc_t *dpr, int exec) > static void > dt_proc_waitrun(dt_proc_t *dpr) > { > -printf("%s:%s(%d): DOODAD\n",__FUNCTION__,__FILE__,__LINE__); > + printf("%s:%s(%d): not implemented\n", __FUNCTION__, __FILE__, > + __LINE__); > #ifdef DOODAD > struct ps_prochandle *P = dpr->dpr_proc; > const lwpstatus_t *psp = &Pstatus(P)->pr_lwp; >