From owner-freebsd-current@freebsd.org Mon Jul 9 10:55:41 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21366103E411 for ; Mon, 9 Jul 2018 10:55:41 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A7A9D90EDC for ; Mon, 9 Jul 2018 10:55:40 +0000 (UTC) (envelope-from jhs@berklix.com) Received: by mailman.ysv.freebsd.org (Postfix) id 6849A103E410; Mon, 9 Jul 2018 10:55:40 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 556B0103E40F for ; Mon, 9 Jul 2018 10:55:40 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from land.berklix.org (land.berklix.org [144.76.10.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "land.berklix.org", Issuer "land.berklix.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C06A990EDA for ; Mon, 9 Jul 2018 10:55:39 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mart.js.berklix.net (pD9FA8EA3.dip0.t-ipconnect.de [217.250.142.163]) (authenticated bits=0) by land.berklix.org (8.15.2/8.15.2) with ESMTPSA id w699oEpi068130 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 9 Jul 2018 09:50:18 GMT (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id w699oDr8047896 for ; Mon, 9 Jul 2018 11:50:14 +0200 (CEST) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.7/8.14.7) with ESMTP id w699o1jF022468 for ; Mon, 9 Jul 2018 11:50:13 +0200 (CEST) (envelope-from jhs@berklix.com) Message-Id: <201807090950.w699o1jF022468@fire.js.berklix.net> To: current@freebsd.org Subject: sys/Makefile .if defined(MODULES_WITH_WORLD) From: "Julian H. Stacey" Organization: http://berklix.eu BSD Linux Unix Consultants, Munich Germany User-agent: EXMH on FreeBSD http://www.berklix.eu/free/ X-From: http://www.berklix.eu/~jhs/ Date: Mon, 09 Jul 2018 11:50:01 +0200 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2018 10:55:41 -0000 Hi current@ src/sys/dev/amdsbwd/amdsbwd.c broke src/sys/modules Is it immediately intuitive & well known to developers working in sys/dev to enable MODULES_WITH_WORLD before a test make all before a commit ? Or what should we do to increase the liklehood of commiters catching modules/ errors before a commit ? With src/ .ctm_status src-cur 13573 .svn_revision 335362 sys/Makefile has .if defined(MODULES_WITH_WORLD) SUBDIR+=modules & nothing from cd /usr/src; find . -name \*src.conf\* & no default /etc/src.conf with no MODULES_WITH_WORLD=YES so make all does not build /sys/modules/ so this not seen from /sys/modules/ ===> amdsbwd (all) cc -O2 -pipe -DBERKLIX=YES -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I/data/release/s1/usr/src/sys -I/data/release/s1/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD -MF.depend.amdsbwd.o -MTamdsbwd.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 -c /data/release/s1/usr/src/sys/dev/amdsbwd/amdsbwd.c -o amdsbwd.o /data/release/s1/usr/src/sys/dev/amdsbwd/amdsbwd.c:52:10: fatal error: 'opt_amdsbwd.h' file not found #include "opt_amdsbwd.h" PS With .ctm_status src-cur 13601 .svn_revision 336117 nothing from find . -name opt_amdsbwd.h but this has src/sys/dev/amdsbwd/amdsbwd.c #include "opt_amdsbwd.h" I haven't yet upgraded my src/ yet to see if it still fails. Cheers, Julian -- Julian Stacey, Computer Consultant, Systems Engineer, BSD Linux Unix, Munich Brexit Referendum stole 3.7 million votes inc. from 700,000 British in EU. UK Goverment lies it's democratic in Article 50 paragraph 3 of letter to EU. http://berklix.eu/queen/ https://www.peoples-vote.uk 193,000 @ 8 Jul 2018