From owner-svn-src-all@FreeBSD.ORG Tue Oct 29 14:45:17 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 230A8DAA; Tue, 29 Oct 2013 14:45:17 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mail.egr.msu.edu (hill.egr.msu.edu [35.9.37.162]) by mx1.freebsd.org (Postfix) with ESMTP id E81DA2BD1; Tue, 29 Oct 2013 14:45:16 +0000 (UTC) Received: from hill (localhost [127.0.0.1]) by mail.egr.msu.edu (Postfix) with ESMTP id A8CDD2DA57; Tue, 29 Oct 2013 10:35:53 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mail.egr.msu.edu ([127.0.0.1]) by hill (hill.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CYXjthznXqce; Tue, 29 Oct 2013 10:35:53 -0400 (EDT) Received: from daemon.localdomain (daemon.egr.msu.edu [35.9.44.65]) by mail.egr.msu.edu (Postfix) with ESMTP id 83F1D2DA50; Tue, 29 Oct 2013 10:35:53 -0400 (EDT) Received: by daemon.localdomain (Postfix, from userid 21281) id 7F4A5290B81; Tue, 29 Oct 2013 10:35:53 -0400 (EDT) Date: Tue, 29 Oct 2013 10:35:53 -0400 From: Adam McDougall To: jlh@FreeBSD.org Subject: Re: svn commit: r254974 - in head: etc/defaults etc/periodic/monthly etc/periodic/security etc/periodic/weekly share/man/man5 Message-ID: <20131029143553.GO1807@egr.msu.edu> References: <201308272120.r7RLKTvk066897@svn.freebsd.org> <20131021000110.GJ2097@egr.msu.edu> <20131028211700.GB37879@caravan.chchile.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131028211700.GB37879@caravan.chchile.org> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Oct 2013 14:45:17 -0000 On Mon, Oct 28, 2013 at 10:17:00PM +0100, Jeremie Le Hen wrote: Hi Adam, On Sun, Oct 20, 2013 at 08:01:10PM -0400, Adam McDougall wrote: > Thanks for working on this, I look forward to taking advantage of it! > > I have a system with some old style adjustments in periodic.conf but > the compat shim doesn't seem to be working (it is running r255793). > I filed PR conf/183137 with more details. Sorry for the late reply, I was abroad. Can you test the following patch please? Index: etc/defaults/periodic.conf =================================================================== --- etc/defaults/periodic.conf (revision 255169) +++ etc/defaults/periodic.conf (working copy) @@ -319,7 +319,7 @@ security_daily_compat_var() { local var=$1 dailyvar value - dailyvar=daily_status_security${#status_security} + dailyvar=daily_status_security${var#status_security} periodvar=${var%enable}period eval value=\"\$$dailyvar\" [ -z "$value" ] && return -- Jeremie Le Hen Sorry, that didn't work (on r255793). Hand applied by adding the 'var', was that the only change? Thanks.