From owner-svn-src-all@freebsd.org Thu Oct 22 19:43:44 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 54BB542919F; Thu, 22 Oct 2020 19:43:44 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CHHq41fZXz4QpV; Thu, 22 Oct 2020 19:43:44 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 145151ACCA; Thu, 22 Oct 2020 19:43:44 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f174.google.com with SMTP id h12so2216268qtu.1; Thu, 22 Oct 2020 12:43:44 -0700 (PDT) X-Gm-Message-State: AOAM531ScPAH3BjztWL4MGeraw3vXTy6d4POX64AngjWW+1Mhjg+DhFm h2QFKU8XbhRM1EPKrq9Wyiq2utAvoCmfPH9orOo= X-Google-Smtp-Source: ABdhPJwm+Pjx8Rj4nnZSpMU75FWwJCpK82ttNWM/oob9+ieNc0KkP432LGyEVDnMDN3kGCKkisG6pHYpR4x6WHkHG40= X-Received: by 2002:ac8:33e8:: with SMTP id d37mr3444053qtb.310.1603395823515; Thu, 22 Oct 2020 12:43:43 -0700 (PDT) MIME-Version: 1.0 References: <202010021826.092IQfdj023808@repo.freebsd.org> <44421602932538@mail.yandex.ru> <43251602934532@mail.yandex.ru> <59021602950992@mail.yandex.ru> In-Reply-To: From: Kyle Evans Date: Thu, 22 Oct 2020 14:43:31 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf To: Niclas Zeising Cc: Warner Losh , "Alexander V. Chernikov" , Hans Petter Selasky , Emmanuel Vadot , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 19:43:44 -0000 On Thu, Oct 22, 2020 at 2:35 PM Niclas Zeising wrote: > > On 2020-10-22 15:22, Kyle Evans wrote: > > On Sat, Oct 17, 2020 at 11:40 AM Warner Losh wrote: > >> > >> > >> > >> On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov wrote: > >>> > >>> 17.10.2020, 14:07, "Hans Petter Selasky" : > >>> > >>> On 2020-10-17 14:34, Alexander V. Chernikov wrote: > >>> > >>> 17.10.2020, 12:32, "Hans Petter Selasky" : > >>> > >>> On 2020-10-17 13:27, Alexander V. Chernikov wrote: > >>> > >>> 02.10.2020, 19:26, "Emmanuel Vadot" >>> >: > >>> > >>> Author: manu > >>> Date: Fri Oct 2 18:26:41 2020 > >>> New Revision: 366372 > >>> URL: https://svnweb.freebsd.org/changeset/base/366372 > >>> > >>> Log: > >>> linuxkpi: Add backlight support > >>> > >>> Add backlight function to linuxkpi. > >>> Graphics drivers expose the backlight of the panel directly so > >>> allow them > >>> to use the backlight subsystem so > >>> user can use backlight(8) to configure them. > >>> > >>> Reviewed by: hselasky > >>> Relnotes: yes > >>> Differential Revision: The FreeBSD Foundation > >>> > >>> Added: > >>> head/sys/compat/linuxkpi/common/include/linux/backlight.h > >>> (contents, > >>> props changed) > >>> Modified: > >>> head/sys/compat/linuxkpi/common/include/linux/device.h > >>> head/sys/compat/linuxkpi/common/src/linux_kmod.c > >>> head/sys/compat/linuxkpi/common/src/linux_pci.c > >>> head/sys/conf/kmod.mk > >>> > >>> It breaks the build for me with > >>> /usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10: > >>> fatal error: 'backlight_if.h' file not found > >>> > >>> > >>> How do you build? Doesn't break over here. > >>> > >>> GENERIC + COMPAT_LINUXKPI. > >>> > >>> > >>> > >>> Try adding: > >>> > >>> options backlight > >>> > >>> To the kernel config. > >>> > >>> Yep, thank you! > >>> Maybe it's worth considering adding static assert with the message describing this dependency? > >> > >> > >> Yes. It likely is worth doing something to highlight this issue. > >> > >> Warner > >> > > > > I think we just need to slap the two core backlight files with an ` | > > compat_linux` so that they simply get pulled in if you specify > > COMPAT_LINUX. config(8) handles this terribly, configng must have a > > better provides/requires/implies/whatever functionality so we can > > specify that compat_linux implies backlight and not do crud like this > > where it becomes more complicated to see what any given option really > > entails. > > > > Thanks, > > COMPAT_LINUX can't be right. Isn't that the linuxolator? > Regards > -- > Niclas Zeising Whoops, s/LINUX/LINUXKPI/ :-)