From owner-svn-src-all@FreeBSD.ORG  Thu Apr 15 06:19:04 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AFE44106566B;
	Thu, 15 Apr 2010 06:19:04 +0000 (UTC)
	(envelope-from luigi@onelab2.iet.unipi.it)
Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238])
	by mx1.freebsd.org (Postfix) with ESMTP id 661BE8FC12;
	Thu, 15 Apr 2010 06:19:04 +0000 (UTC)
Received: by onelab2.iet.unipi.it (Postfix, from userid 275)
	id C8FE573098; Thu, 15 Apr 2010 08:29:31 +0200 (CEST)
Date: Thu, 15 Apr 2010 08:29:31 +0200
From: Luigi Rizzo <rizzo@iet.unipi.it>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20100415062931.GA92769@onelab2.iet.unipi.it>
References: <201004121637.o3CGbjSK080066@svn.freebsd.org>
	<20100412204926.GB1743@garage.freebsd.pl>
	<20100412210512.GB94885@onelab2.iet.unipi.it>
	<20100414074616.GA1657@garage.freebsd.pl>
	<20100414081630.GA74130@onelab2.iet.unipi.it>
	<20100414160554.GB3188@gandalf.sssup.it>
	<20100414210117.GA2252@garage.freebsd.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100414210117.GA2252@garage.freebsd.pl>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@FreeBSD.org, Luigi Rizzo <luigi@FreeBSD.org>,
	src-committers@FreeBSD.org, svn-src-all@FreeBSD.org,
	Fabio Checconi <fabio@FreeBSD.org>
Subject: Re: svn commit: r206497 - in head: sbin/geom/class
	sbin/geom/class/sched sys/geom/sched sys/modules/geom
	sys/modules/geom/geom_sched sys/modules/geom/geom_sched/gs_sched
	sys/modules/geom/geom_sched/gsc...
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2010 06:19:04 -0000

On Wed, Apr 14, 2010 at 11:01:17PM +0200, Pawel Jakub Dawidek wrote:
> On Wed, Apr 14, 2010 at 06:05:54PM +0200, Fabio Checconi wrote:
> >   - Some classes (from a quick look I've seen only g_mirror, but I'm
> >     pretty sure there were some other ones) cache pointers to their
> >     providers.  With these classes this implementation does not work.
> 
> This can be easly changed to go though geom to provider. Many of my
> classes do that.

Absolutely. The above was just to explain why we only implemented
insert/remove within geom_sched instead of globally. If/when we
make the feature globally available, we also need to inspect all
classes to make sure that there are no surprises.

cheers
luigi

> 
> -- 
> Pawel Jakub Dawidek                       http://www.wheelsystems.com
> pjd@FreeBSD.org                           http://www.FreeBSD.org
> FreeBSD committer                         Am I Evil? Yes, I Am!