From owner-freebsd-current@freebsd.org Sun Dec 29 00:30:11 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DC3C31CD073 for ; Sun, 29 Dec 2019 00:30:11 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670073.outbound.protection.outlook.com [40.107.67.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47lhKZ4Wbwz3QGN for ; Sun, 29 Dec 2019 00:30:10 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBpiLLUPTS8zWKbGUSsDTVL+gAo2N1C3mq51SoES6EiN8enADMZvexHga998zSy3tvO99L5G1bSTy5t/Zn+x2uCi+6CzDQoENrZFGQA6o11O82Qh5iAkg7RtisxyU/VO8TwLdCLRuVC0rqcpP+67pmS7trO6AuqkPJFylSx7fcNi5NQiZ2VX8MlnN/bEBJwkfZi3aLzKWc39o7rELOrWtttiJaMNQRyRmzTWz0PaTWCXqysZQ0DaDlx7LoZnEZSzft9shPaSyHLki+lANp5nimCMj6/xox5mfyOhAZRgzuUeav9pZX+DQzXjcuZwYG1Xzu+61umXE9ceu3bEC42seg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/YPbhaMR/VjpUB0R3XwO+2Ly3Rn88GZi16ExGixnYvc=; b=YvizOs93jncM03TY6d6zIfXNO0XnDSS2pGQl1oBNfYcnqBX68lIjiRmpx6x6X3fwgzDATmMZQAAJtGYSYWaHhzBT2dVViLSAMol6V3ClozsRGpzIHKlsm2YofrDWNpQD1LZJtMd+fWqPkBvVpPtLvi+ALY7B7ZU+uvoXZZfZpfovnLYKHmuiQvz6kIjLQji9K3X9uiA9z7bWi+dvySaAtA/tNV+LYEXiQo5fznQVbrOwNBy7KpRy7OcO+YgmTy0pdDA5of+PAAeyyhYB7lA9vmX8Qsi3pT77fKIP9oOCpAOGL/n1KjYvaa3sXKjaneDjLCTbUiGURHxSgPny6R1ZvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM (52.132.69.153) by YQBPR0101MB1745.CANPRD01.PROD.OUTLOOK.COM (52.132.71.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.11; Sun, 29 Dec 2019 00:30:08 +0000 Received: from YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94]) by YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM ([fe80::7512:8580:8d82:6c94%6]) with mapi id 15.20.2581.007; Sun, 29 Dec 2019 00:30:08 +0000 From: Rick Macklem To: "freebsd-current@freebsd.org" Subject: getting rid of sys/nfs/nfs_lock.c Thread-Topic: getting rid of sys/nfs/nfs_lock.c Thread-Index: AQHVvd4uYot+uGDYskWjg23o3Tr07A== Date: Sun, 29 Dec 2019 00:30:08 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 03545925-7243-41a0-ab56-08d78bf64232 x-ms-traffictypediagnostic: YQBPR0101MB1745: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0266491E90 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(396003)(136003)(39860400002)(189003)(199004)(786003)(4744005)(8936002)(52536014)(5660300002)(186003)(316002)(55016002)(33656002)(9686003)(6506007)(71200400001)(7696005)(64756008)(66556008)(6916009)(86362001)(81166006)(66446008)(76116006)(8676002)(66476007)(66946007)(81156014)(478600001)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1745; H:YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2G6gZL5MMU8RXYv32QQGV5ENL4Ms5QF4pS4RqRzacwRaOcIKpO/9qgKIIla6M+0FjtwL6MY+ur4jWHKLdLEtC+zCSi4F89N+xR7+UkSna/IdOXaZXvFOF56n9i9Qo7YB0TuD27HGEzB1vyf0sZFXZm7kiFP5yVoLeJ95Dt8soewhhdFarn2cx0nrbIU+qeiUMnk2mSCeX31XiPguWbKv3+kpkM2nDGCegSrWIvYAC5gEC7xw2Cuwl6Not9v1narKXbnd5gjOkVO7rTWNI120uvS1vakGMo7XqR10nLPYZfLZ3EVswd+JzCGrOm6MDyFQj822jJmdqiJWDSNHLDXEmyRF2K/ZY8dKEvgQd3oVJ50o0iCs9wnET41n7gJB2gYZGVVfa4yjRxY+TxsvXWwneQwIJC0jitwtR4GUEj/rlwvWPLRW9PdLKAxLoHkjDuAx x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 03545925-7243-41a0-ab56-08d78bf64232 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2019 00:30:08.2548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rz6G38HBKuTtXkB/vMzws0LQmB3izTrzx9ajqAFXRHVkYLXi0O119EAq7wdSM+9Lp7V1RsW3Zws0dUvrhwVEaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1745 X-Rspamd-Queue-Id: 47lhKZ4Wbwz3QGN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.73 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.67 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.37)[ipnet: 40.64.0.0/10(-3.84), asn: 8075(-2.94), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[73.67.107.40.list.dnswl.org : 127.0.3.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Dec 2019 00:30:11 -0000 Hi,=0A= =0A= sys/nfs/nfs_lock.c uses Giant. Since it has not been used by default since= =0A= March 2008, I suspect it can be removed from head without any impact.=0A= Post March 2008, the only way this code could be executed is by both=0A= building a kernel without "options NFSLOCKD" and deleting nfslockd.ko=0A= from the kernel boot directory and then running rpc.lockd on the system.=0A= =0A= I doubt anyone has been doing both of the above, but if you think it is=0A= still useful, please speak up. (I have an untested patch that replaces Gian= t=0A= with a regular mutex. I realized this code is not used when I trying to tes= t it.;-)=0A= =0A= Also, if it seems appropriate, I could commit a patch that makes it print o= ut=0A= "deprecated and going away before FreeBSD 13" message, but I doubt anyone= =0A= will ever see it.=0A= Should I do such a message and wait a few months for the deletion?=0A= =0A= Thanks for your comments, rick=0A= ps: The current patch that prepares the kernel for deletion of sys/nfs/nfs_= lock.c=0A= is in reviews.freebsd.org/D22933.=0A= =0A=