From owner-freebsd-fs@freebsd.org  Thu Sep 21 16:51:50 2017
Return-Path: <owner-freebsd-fs@freebsd.org>
Delivered-To: freebsd-fs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD1CEE103EE
 for <freebsd-fs@mailman.ysv.freebsd.org>; Thu, 21 Sep 2017 16:51:50 +0000 (UTC)
 (envelope-from longwitz@incore.de)
Received: from dss.incore.de (dss.incore.de [195.145.1.138])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 82100A17
 for <freebsd-fs@freebsd.org>; Thu, 21 Sep 2017 16:51:49 +0000 (UTC)
 (envelope-from longwitz@incore.de)
Received: from inetmail.dmz (inetmail.dmz [10.3.0.3])
 by dss.incore.de (Postfix) with ESMTP id 36B82F0C;
 Thu, 21 Sep 2017 18:51:47 +0200 (CEST)
X-Virus-Scanned: amavisd-new at incore.de
Received: from dss.incore.de ([10.3.0.3])
 by inetmail.dmz (inetmail.dmz [10.3.0.3]) (amavisd-new, port 10024)
 with LMTP id bCzo0qt1h4Tf; Thu, 21 Sep 2017 18:51:46 +0200 (CEST)
Received: from mail.local.incore (fwintern.dmz [10.0.0.253])
 by dss.incore.de (Postfix) with ESMTP id 4704FC68;
 Thu, 21 Sep 2017 18:51:46 +0200 (CEST)
Received: from bsdlo.incore (bsdlo.incore [192.168.0.84])
 by mail.local.incore (Postfix) with ESMTP id 1E6A4508D6;
 Thu, 21 Sep 2017 18:51:46 +0200 (CEST)
Message-ID: <59C3EE21.1010401@incore.de>
Date: Thu, 21 Sep 2017 18:51:45 +0200
From: Andreas Longwitz <longwitz@incore.de>
User-Agent: Thunderbird 2.0.0.19 (X11/20090113)
MIME-Version: 1.0
To: gljennjohn@gmail.com, freebsd-fs@freebsd.org
Subject: Re: fsync: giving up on dirty on ufs partitions running
 vfs_write_suspend()
References: <201709110519.v8B5JVmf060773@chez.mckusick.com>	<59BD0EAC.8030206@incore.de>	<20170916183117.GF78693@kib.kiev.ua>	<59C37F46.80509@incore.de>
 <20170921125858.64ffe077@ernst.home>
In-Reply-To: <20170921125858.64ffe077@ernst.home>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Sep 2017 16:51:50 -0000

Gary Jennejohn schrieb:

>> So the spent time in vop_stdfsync() is 0,24 sec in the worst case I
>> found using DELAY with 1 ms. I would prefer this solution. My first
>> appoach (simple bumping maxres from 1000 to 100000) is also ok, but max
>> spend time will be raise up to 0,5 sec. Perhaps you like something like
>>
>>    if( maxretry < 1000 && maxretry % 10 = 0)
>                                       ^ ==
>>           DELAY(waitns);
>>
> 
> The argument to DELAY is in micro-seconds.
> 

Thanks for your hint.
Correct is
     waitns = 1000;
     if( maxretry < 1000 && maxretry % 10 == 0)
        DELAY(waitns);

Andreas Longwitz