From owner-svn-src-head@FreeBSD.ORG Fri Nov 19 21:27:29 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 39266106567A; Fri, 19 Nov 2010 21:27:29 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com [209.85.216.175]) by mx1.freebsd.org (Postfix) with ESMTP id A780E8FC0C; Fri, 19 Nov 2010 21:27:28 +0000 (UTC) Received: by qyk8 with SMTP id 8so105274qyk.13 for ; Fri, 19 Nov 2010 13:27:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=Kvqa2XbWDw+KpaxEUfkEsjSIT5vOCa4s/CSS9arBWME=; b=ccWyTnaI5wAsoYSS8wRC14DygqBkNDZz7O8oJXp42sbCYKrEPBpRSRhyQiO9oLI/ku x/xswi98hOTIGoImwrn+tN/e9Jvn6sD7KHGQUDUwIeHjaUfsEw1iLEBpBINSvG9tPpXp RFvtgbk2vhBWmn0qmsmuFwqGIq7p80IXBqBuw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=FTG6IWh1Yw44EEWjyviSktfybMAqiZfssr5n5SrEJhutCEJS9hohpx5v8fGWWHqis+ 3O67yC/U5JP01wJaHag7B4OTwvw4E1ldzg+V20etA1PqgV6Jj3nmmSn0Hi6VZnVHTUwC ORXL09eR6GddG/dBOeI5Cd5oO5vrR9qPvpoC4= MIME-Version: 1.0 Received: by 10.229.190.204 with SMTP id dj12mr2208872qcb.66.1290202047858; Fri, 19 Nov 2010 13:27:27 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.229.31.9 with HTTP; Fri, 19 Nov 2010 13:27:27 -0800 (PST) In-Reply-To: <201011191617.51552.jhb@freebsd.org> References: <201011191943.oAJJhv3i087205@svn.freebsd.org> <201011191617.51552.jhb@freebsd.org> Date: Fri, 19 Nov 2010 16:27:27 -0500 X-Google-Sender-Auth: 6JuuWjj4sgvpEHr-MRlc53qx_Uc Message-ID: From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215544 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Nov 2010 21:27:29 -0000 2010/11/19 John Baldwin : > On Friday, November 19, 2010 2:43:57 pm Attilio Rao wrote: >> Author: attilio >> Date: Fri Nov 19 19:43:56 2010 >> New Revision: 215544 >> URL: http://svn.freebsd.org/changeset/base/215544 >> >> Log: >> =C2=A0 Scan the list in reverse order for the shutdown handlers of loade= d modules. >> =C2=A0 This way, when there is a dependency between two modules, the han= dler of the >> =C2=A0 latter probed runs first. >> >> =C2=A0 This is a similar approach as the modules are unloaded in the sam= e >> =C2=A0 linkerfile. >> >> =C2=A0 Sponsored by: =C2=A0 =C2=A0 =C2=A0 Sandvine Incorporated >> =C2=A0 Submitted by: =C2=A0 =C2=A0 =C2=A0 Nima Misaghian >> =C2=A0 MFC after: =C2=A01 week >> >> Modified: >> =C2=A0 head/sys/kern/kern_module.c >> >> Modified: head/sys/kern/kern_module.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/kern/kern_module.c =C2=A0 =C2=A0 =C2=A0 Fri Nov 19 18:59:35= 2010 =C2=A0 =C2=A0 =C2=A0 =C2=A0(r215543) >> +++ head/sys/kern/kern_module.c =C2=A0 =C2=A0 =C2=A0 Fri Nov 19 19:43:56= 2010 =C2=A0 =C2=A0 =C2=A0 =C2=A0(r215544) >> @@ -46,7 +46,7 @@ __FBSDID("$FreeBSD$"); >> >> =C2=A0static MALLOC_DEFINE(M_MODULE, "module", "module data structures")= ; >> >> -typedef TAILQ_HEAD(, module) modulelist_t; >> +typedef TAILQ_HEAD(modulelst, module) modulelist_t; > > Is modulelist already taken? =C2=A0If not, we should probably just retire > 'modulelist_t' and replace it with 'struct modulelist'. Note that I used modulelst, not modulelist. Probabilly, if you think the name may be still confusing, we can pickup one another further. Attilio --=20 Peace can only be achieved by understanding - A. Einstein