From owner-freebsd-net@FreeBSD.ORG  Tue Jul 28 16:18:15 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 397F21065670
	for <freebsd-net@freebsd.org>; Tue, 28 Jul 2009 16:18:15 +0000 (UTC)
	(envelope-from os@sfedu.ru)
Received: from mail.r61.net (mail.r61.net [195.208.245.249])
	by mx1.freebsd.org (Postfix) with ESMTP id A7F428FC18
	for <freebsd-net@freebsd.org>; Tue, 28 Jul 2009 16:18:14 +0000 (UTC)
	(envelope-from os@sfedu.ru)
Received: from mind.local (os.adsl.r61.net [195.208.243.95])
	(authenticated bits=0)
	by mail.r61.net (8.14.3/8.14.1) with ESMTP id n6SGI8Ef022623
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
	Tue, 28 Jul 2009 20:18:09 +0400 (MSD) (envelope-from os@sfedu.ru)
X-Authentication-Warning: asterix.r61.net: Host os.adsl.r61.net
	[195.208.243.95] claimed to be mind.local
Message-ID: <4A6F24BB.7050907@sfedu.ru>
Date: Tue, 28 Jul 2009 20:18:03 +0400
From: Oleg Sharoyko <os@sfedu.ru>
User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605)
MIME-Version: 1.0
To: Julian Elischer <julian@elischer.org>
References: <1248704237.96833.127.camel@brain.cc.rsu.ru>	
	<4A6DE356.6040006@elischer.org> <4A6DEE30.6000108@sfedu.ru>	
	<4A6DFFA1.1010709@elischer.org> <4A6E0121.2020004@sfedu.ru>	
	<4A6E05EC.8050401@elischer.org> <4A6E0A8B.5000103@sfedu.ru>	
	<4A6E2666.2040906@elischer.org> <4A6E3743.7050708@elischer.org>
	<1248788292.71222.10.camel@brain.cc.rsu.ru>
	<4A6F1D76.7040806@elischer.org>
In-Reply-To: <4A6F1D76.7040806@elischer.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@freebsd.org
Subject: Re: Wrong outgoing interface with multiple routing tables
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2009 16:18:15 -0000

Julian Elischer wrote:

> I'll get that checked in!

Please, also take a look at

_syncache_add() in tcp_syncache.c

There is some code which looks strange, at least at first sight. Won't 
bcopy() overwrite assigned value of sc->sc_inc.inc_fibnum ?

         /* XXX-BZ this fib assignment is just useless. */
         sc->sc_inc.inc_fibnum = inp->inp_inc.inc_fibnum;
         bcopy(inc, &sc->sc_inc, sizeof(struct in_conninfo));

--
Oleg