From nobody Mon Feb 9 06:56:44 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f8b8Y27dPz6Qgdb for ; Mon, 09 Feb 2026 06:56:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f8b8Y1Pjxz45wm for ; Mon, 09 Feb 2026 06:56:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770620205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2843nI2RCHjFFZno7WDyNQ+892gFg2uT3bQH5GHJs10=; b=j51QNaj/rIB0odfuKkPi81F10NQ8/6FmMbiC3BYhKsxjWmAM0gbiErWTYWo0tdgeGKPyAz gZiiSCqONHT8nmTqolS1qIgTpMyvaxhQ72eExqVu+xYJsoRLDENgA9emS3n/X0aVN9fD1X iv758/E1Q2LhimRnMnj21XK83KDMoO0YXUPKfheXwDxVCyAFQRKJmMrLx1P8hrFpd90MTg GmrTv2qahaPqU5FWFh3riOQhJoorpsDCAl0w5VOoHNf1Lf7xX4H3hUCRkV1FT6W8lOpaDW T4PRgrMnxkSnkTiXLWeA+5k3Nf5zh0jDgse/cjKI4VWPcBjsCRHCaw2hHDsa/A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770620205; a=rsa-sha256; cv=none; b=vZuWPPlOvnH8v7vt9bJi7BTStN88ZtqCppAd/wz7pNqIspHEBzpR08RPcPbEBJVD7noNrD 8VrGNjiDZVl9XNojp7/YXsE5TidmHvvZAfAZDtkknoLuMf6ZT911QsPGxeblqp8JaXk7SJ zx2o9zcrq+WwTQ74WkYqo7Wn8/aQNY5TPYyEdZ9tdwjjksm+4B22B+6N5X2ThEn+EfGJg5 EVzhTABTVdRNYi+iDGXwgq0k7XbXmQ/n3TvrjxIMOGkGyGGTBWt6BCnWIvubF4/59Cy8xM MNdPFlTl5w4HHqfKiNK4mSQqOUsKfNppKbIglpCPxmLVeYTCLU6+0kKvRIifDw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770620205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2843nI2RCHjFFZno7WDyNQ+892gFg2uT3bQH5GHJs10=; b=a1o0+Q5gBRwHaLMuwVfchbKFxLBJYeQ4MqZ28gtP33JkDXbjXz2HKmskLqblautVptRXPL jl64dL0IkXzIXDpSRhAsAKBhN5tLH11SwG9DE51+9NQ6bJ6oWFyOZ5a532sZKwVYeBY6DV Pw6YxTm0Wn6URCSTvgG5RlOWTefkxLXka9L4HiM+RXwU1gqVr2v1BY/Djv1GJRsQJf1RuS lb9OFGIPZFRrd+xMhQ2YnU0FcEVX6+DbDGpP+jBaiKIig89VDBcMW1xiofsE2YbPRB7EuS DURb0040j2gy9A9uckHuGUvQMfU/qd2hASM0iBGtHAlxR/bv5iewt9Z17brG1Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f8b8X709Hz5r5 for ; Mon, 09 Feb 2026 06:56:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3990e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 09 Feb 2026 06:56:44 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Yogesh Bhosale From: Kevin Bowling Subject: git: 0c733d04939d - stable/15 - ice(4): Handle allmulti flag in ice_if_promisc_set function List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 0c733d04939db88194472227268fd7468dc2a6ce Auto-Submitted: auto-generated Date: Mon, 09 Feb 2026 06:56:44 +0000 Message-Id: <6989852c.3990e.4a1ef810@gitrepo.freebsd.org> The branch stable/15 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=0c733d04939db88194472227268fd7468dc2a6ce commit 0c733d04939db88194472227268fd7468dc2a6ce Author: Yogesh Bhosale AuthorDate: 2026-02-01 17:27:36 +0000 Commit: Kevin Bowling CommitDate: 2026-02-09 06:56:21 +0000 ice(4): Handle allmulti flag in ice_if_promisc_set function In the ice_if_promisc_set function, the driver currently disables the IFF_ALLMULTI flag, thereby preventing the activation of multicast mode. To address this issue, implement appropriate handling to ensure the flag is managed correctly. Signed-off-by: Yogesh Bhosale Tested by: Gowthamkumar K S Differential Revision: https://reviews.freebsd.org/D54186 (cherry picked from commit 98bdf63f6e94be42a1787de73608de15bcb3419a) --- sys/dev/ice/if_ice_iflib.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/sys/dev/ice/if_ice_iflib.c b/sys/dev/ice/if_ice_iflib.c index 1469d2916465..6ea539d52e02 100644 --- a/sys/dev/ice/if_ice_iflib.c +++ b/sys/dev/ice/if_ice_iflib.c @@ -1907,15 +1907,13 @@ ice_if_promisc_set(if_ctx_t ctx, int flags) ice_set_default_promisc_mask(promisc_mask); - if (multi_enable) - return (EOPNOTSUPP); - if (promisc_enable) { status = ice_set_vsi_promisc(hw, sc->pf_vsi.idx, promisc_mask, 0); if (status && status != ICE_ERR_ALREADY_EXISTS) { device_printf(dev, - "Failed to enable promiscuous mode for PF VSI, err %s aq_err %s\n", + "Failed to enable promiscuous mode for " + "PF VSI, err %s aq_err %s\n", ice_status_str(status), ice_aq_str(hw->adminq.sq_last_status)); return (EIO); @@ -1925,11 +1923,28 @@ ice_if_promisc_set(if_ctx_t ctx, int flags) promisc_mask, 0); if (status) { device_printf(dev, - "Failed to disable promiscuous mode for PF VSI, err %s aq_err %s\n", + "Failed to disable promiscuous mode for" + " PF VSI, err %s aq_err %s\n", ice_status_str(status), ice_aq_str(hw->adminq.sq_last_status)); return (EIO); } + + if (multi_enable) { + ice_clear_bit(ICE_PROMISC_UCAST_TX, promisc_mask); + ice_clear_bit(ICE_PROMISC_UCAST_RX, promisc_mask); + status = ice_set_vsi_promisc(hw, sc->pf_vsi.idx, + promisc_mask, 0); + if (status && status != ICE_ERR_ALREADY_EXISTS) { + device_printf(dev, + "Failed to enable allmulti mode " + "for PF VSI, err %s aq_err %s\n", + ice_status_str(status), + ice_aq_str( + hw->adminq.sq_last_status)); + return (EIO); + } + } } return (0);