From owner-freebsd-bugs@FreeBSD.ORG  Mon Feb 25 13:10:00 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id AF8716D
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon, 25 Feb 2013 13:10:00 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 7EBFFB49
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Mon, 25 Feb 2013 13:10:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r1PDA0gP091694
 for <freebsd-bugs@freefall.freebsd.org>; Mon, 25 Feb 2013 13:10:00 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r1PDA031091693;
 Mon, 25 Feb 2013 13:10:00 GMT (envelope-from gnats)
Resent-Date: Mon, 25 Feb 2013 13:10:00 GMT
Resent-Message-Id: <201302251310.r1PDA031091693@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Nicholas Wilson <nicholas@nicholaswilson.me.uk>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id B9825E8F
 for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Feb 2013 13:02:15 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id AB2B7AF6
 for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Feb 2013 13:02:15 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r1PD2Fog017012
 for <freebsd-gnats-submit@FreeBSD.org>; Mon, 25 Feb 2013 13:02:15 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id r1PD2Fgv017011;
 Mon, 25 Feb 2013 13:02:15 GMT (envelope-from nobody)
Message-Id: <201302251302.r1PD2Fgv017011@red.freebsd.org>
Date: Mon, 25 Feb 2013 13:02:15 GMT
From: Nicholas Wilson <nicholas@nicholaswilson.me.uk>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: kern/176420: [patch] incorrect errno for LOCAL_PEERCRED
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Feb 2013 13:10:00 -0000


>Number:         176420
>Category:       kern
>Synopsis:       [patch] incorrect errno for LOCAL_PEERCRED
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 25 13:10:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Nicholas Wilson
>Release:        Release 7.4 to Release 9.1
>Organization:
>Environment:
FreeBSD EB5-FBSD-7-4-x64.realvnc.ltd 7.4-RELEASE-p9 FreeBSD 7.4-RELEASE-p9 #0: Mon Jun 11 19:47:58 UTC 2012     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
A tiny bug; error code is incorrect for the SEQPACKET retrieval of LOCAL_PEERCRED.

* An unconnected SOCK_STREAM: get ENOTCONN
* A SOCK_DGRAM: get EINVAL
* An unconnected SOCK_SEQPACKET: get EINVAL, but should get ENOTCONN
>How-To-Repeat:

>Fix:
Patch attached for RELEASE-9.1

Patch attached with submission follows:

--- uipc_usrreq.c-9.1-release-r243808   2013-02-25 12:59:06.653391783 +0000
+++ uipc_usrreq.c       2013-02-25 13:00:43.196178074 +0000
@@ -1165,5 +1165,5 @@
                                xu = unp->unp_peercred;
                        else {
-                               if (so->so_type == SOCK_STREAM)
+                               if (so->so_proto->pr_flags & PR_CONNREQUIRED)
                                        error = ENOTCONN;
                                else

>Release-Note:
>Audit-Trail:
>Unformatted: