From owner-svn-src-head@FreeBSD.ORG Fri Dec 2 15:17:41 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4BFFE106566B; Fri, 2 Dec 2011 15:17:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 210898FC0A; Fri, 2 Dec 2011 15:17:41 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id CBE2346B3B; Fri, 2 Dec 2011 10:17:40 -0500 (EST) Received: from John-Baldwins-MacBook-Air.local (c-68-36-150-83.hsd1.nj.comcast.net [68.36.150.83]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 3721BB91E; Fri, 2 Dec 2011 10:17:40 -0500 (EST) Message-ID: <4ED8EC14.6000000@FreeBSD.org> Date: Fri, 02 Dec 2011 10:17:40 -0500 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Joel Dahl References: <201112020038.pB20cmt6068628@svn.freebsd.org> <20111202094411.GJ23987@goofy01.vnodelab.local> In-Reply-To: <20111202094411.GJ23987@goofy01.vnodelab.local> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 02 Dec 2011 10:17:40 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ken Smith Subject: Re: svn commit: r228192 - head/usr.sbin/bsdinstall/scripts X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2011 15:17:41 -0000 On 12/2/11 4:44 AM, Joel Dahl wrote: > On 02-12-2011 0:38, Ken Smith wrote: >> Author: kensmith >> Date: Fri Dec 2 00:38:47 2011 >> New Revision: 228192 >> URL: http://svn.freebsd.org/changeset/base/228192 >> >> Log: >> Add a screen that asks if the user would like to enable crash dumps, >> giving them a very brief description of the trade-offs. Whether the >> user opts in or out add an entry to what will become /etc/rc.conf >> explaining what dumpdev is and how to turn on/off crash dumps. The folks >> who handle interacting with users submitting PRs have asked for this. > > Hmm. Two things I'd like to bring up: > > * Not specifically aimed at this commit, but my recommendation > would be that we keep bsdinstall as simple as possible: installing FreeBSD > should require a minimum amount of keystrokes. I realise this is just one > more screen, but I hope we don't turn bsdinstall into a configuration > utility where you can disable/enable just about anything in rc.conf. > > * Mentioning future system crashes during installation feels awkward. Is that > really what we want? I understand the problem and how this helps us with > debugging, but this is like saying to users that what they are installing > is unstable and that it'll eventuelly crash and die. I know we discussed > ways of making crash dumps smarter in order to not fill up /var, which in > turn would allow us to always have it on. Maybe that is the right path? All non-trivial software has bugs and eventually crashes. I don't expect this to be a surprise to someone installing a UNIX-like operating system. Note that this isn't the PC-BSD installer, but the FreeBSD installer. Also, there have been long discussions about this and ample time for other patches to be developed but they haven't. If you want this changed, implement the alternate solution. Until then this is better than not having it at all. -- John Baldwin