From owner-freebsd-ports-bugs@FreeBSD.ORG  Wed Nov 10 02:20:10 2010
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 820E1106566B
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed, 10 Nov 2010 02:20:10 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 4499C8FC14
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Wed, 10 Nov 2010 02:20:10 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAA2KApk061031
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Wed, 10 Nov 2010 02:20:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAA2KADr061030;
	Wed, 10 Nov 2010 02:20:10 GMT (envelope-from gnats)
Resent-Date: Wed, 10 Nov 2010 02:20:10 GMT
Resent-Message-Id: <201011100220.oAA2KADr061030@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Eitan Adler <lists@eitanadler.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CB30D106566C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 10 Nov 2010 02:10:48 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id BA21B8FC18
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed, 10 Nov 2010 02:10:48 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id oAA2Amke049094
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 10 Nov 2010 02:10:48 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id oAA2AmhS049085;
	Wed, 10 Nov 2010 02:10:48 GMT (envelope-from nobody)
Message-Id: <201011100210.oAA2AmhS049085@www.freebsd.org>
Date: Wed, 10 Nov 2010 02:10:48 GMT
From: Eitan Adler <lists@eitanadler.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: ports/152090: [patch] actually use defaultval instead of $$3
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Nov 2010 02:20:10 -0000


>Number:         152090
>Category:       ports
>Synopsis:       [patch] actually use defaultval instead of $$3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 10 02:20:09 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Eitan Adler
>Release:        
>Organization:
>Environment:
>Description:
Looking through the source of bsd.port.mk I noticed that defaultval was assigned to $$3 but was never actually used. Attached is a patch to make the code clearer.
>How-To-Repeat:

>Fix:
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.654
diff -u -r1.654 bsd.port.mk
--- bsd.port.mk	8 Nov 2010 16:07:03 -0000	1.654
+++ bsd.port.mk	10 Nov 2010 01:57:25 -0000
@@ -6035,7 +6035,7 @@
 		elif [ ! -z "$${withoutval}" ]; then \
 			val=off; \
 		else \
-			val=$$3; \
+			val=$${defaultval}; \
 		fi; \
 		DEFOPTIONS="$${DEFOPTIONS} $$1 \"$$2\" $${val}"; \
 		shift 3; \
@@ -6140,7 +6140,7 @@
 		elif [ ! -z "$${withoutval}" ]; then \
 			val=off; \
 		else \
-			val="$$3 (default)"; \
+			val="$${defaultval} (default)"; \
 		fi; \
 		${ECHO_MSG} "     $$1=$${val} \"$$2\""; \
 		shift 3; \


>Release-Note:
>Audit-Trail:
>Unformatted: