From owner-freebsd-emulation@FreeBSD.ORG Thu Apr 2 12:24:59 2009 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB51D1065676; Thu, 2 Apr 2009 12:24:59 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: from ey-out-2122.google.com (ey-out-2122.google.com [74.125.78.25]) by mx1.freebsd.org (Postfix) with ESMTP id 171B88FC26; Thu, 2 Apr 2009 12:24:58 +0000 (UTC) (envelope-from rpaulo@gmail.com) Received: by ey-out-2122.google.com with SMTP id 4so106369eyf.7 for ; Thu, 02 Apr 2009 05:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:cc:message-id:from:to :in-reply-to:content-type:content-transfer-encoding:mime-version :subject:date:references:x-pgp-agent:x-mailer; bh=eOoxMHnmlhD7e+bO++hEk1qBUiewO4bV66i0Xk3Bbt0=; b=B9OXBnrOPK2g+sFW4xJFeWcHyKLFTAQv19VvVEnhiKGXOb79DDM87cnMTikjrBW6zO y0/wmI7pWKyxH5NujbStYF0N/efNroTpy0D0rKgvosOD4owbVaLWo52p0K+DVy5MoTjv bzbImyhVrIJ4y8sGbdknWreYi45feAA3tOn8A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:cc:message-id:from:to:in-reply-to:content-type :content-transfer-encoding:mime-version:subject:date:references :x-pgp-agent:x-mailer; b=oGMtw6wd82jSPZK4sxwBpeH3P5Im61INAjRPgquUn//1+44cn78ejz3/8rOWPWJ5iu MBKoaanL/XC6sl4Ym0PnZ4A4vEJmR77FZxrFUWN/RIp9t7bQxcTmJBfVLQxb99WaWHoG 4ZK4Z4JlIi3vZVH1YtwckWRbspEzuo9xAkg24= Received: by 10.216.21.76 with SMTP id q54mr2981608weq.153.1238673501169; Thu, 02 Apr 2009 04:58:21 -0700 (PDT) Received: from epsilon.lan (bl6-146-140.dsl.telepac.pt [82.155.146.140]) by mx.google.com with ESMTPS id 28sm1394019eyg.15.2009.04.02.04.58.20 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 02 Apr 2009 04:58:20 -0700 (PDT) Sender: Rui Paulo Message-Id: <0FACAA06-8675-4793-B485-9F7229DDACD8@FreeBSD.org> From: Rui Paulo To: Jung-uk Kim In-Reply-To: <200903261249.00104.jkim@FreeBSD.org> Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Apple-Mail-1-520774333" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Date: Thu, 2 Apr 2009 12:58:15 +0100 References: <962f2e5dc273dac6f2a2aaf017763bb2@iem.pw.edu.pl> <200903261249.00104.jkim@FreeBSD.org> X-Pgp-Agent: GPGMail 1.2.0 (v56) X-Mailer: Apple Mail (2.930.3) Cc: =?UTF-8?Q?J=C4=99drzej_Kalinowski?= , freebsd-emulation@FreeBSD.org Subject: Re: qemu 0.10.1 PCAP networking on CURRENT X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2009 12:25:00 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --Apple-Mail-1-520774333 Content-Type: text/plain; charset=UTF-8; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable On 26 Mar 2009, at 16:48, Jung-uk Kim wrote: > [CC added] > > On Thursday 26 March 2009 04:55 am, J=C4=99drzej Kalinowski wrote: >> Hi, >> >> I'm working with latest qemu port (0.10.1) submitted by Juergen >> Lock. Pcap networking didn't work ok for me - it was terribly slow. >> >> I'm on a 8.0-CURRENT system, so I don't know if it is also the case >> in older releases. Nevertheless, if someone experiences similiar >> problems, you can try this patch - it helped me: > > --- (PATCH removed) --- > > libpcap 1.0.0 was imported few days ago but it didn't merge the > following local hack: > > = http://www.freebsd.org/cgi/cvsweb.cgi/src/contrib/libpcap/pcap.h.diff?r1=3D= 1.13;r2=3D1.14 > > Your patch is harmless but it should be fixed in pcap.h and/or > net/bpf.h properly not to step on each other unless the plan is to > add PCAP_DONT_INCLUDE_PCAP_BPF_H everywhere in our ports tree to get > FreeBSD-specific definitions. For example, the QEMU patch needs at > least two ioctl definitions to get it really working, i.e., > BIOCIMMEDIATE and BIOCFEEDBACK, which are only present in net/bpf.h. > In fact, pcap-bpf.c itself has a hack for AIX like this: > > #ifdef _AIX > > /* > * Make "pcap.h" not include "pcap/bpf.h"; we are going to include the > * native OS version, as we need "struct bpf_config" from it. > */ > #define PCAP_DONT_INCLUDE_PCAP_BPF_H > > #include > > /* > * Prevent bpf.h from redefining the DLT_ values to their > * IFT_ values, as we're going to return the standard libpcap > * values, not IBM's non-standard IFT_ values. > */ > #undef _AIX > #include > #define _AIX > > ... > > #else /* _AIX */ > > #include > > #endif /* _AIX */ > > This is absolutely disgusting. IMHO, I don't think it is a good idea > to pollute ports tree with local patches like that. Sorry for the late reply. You're right that this is a miss on my side. =20= I'll fix it. Sorry, -- Rui Paulo --Apple-Mail-1-520774333 content-type: application/pgp-signature; x-mac-type=70674453; name=PGP.sig content-description: This is a digitally signed message part content-disposition: inline; filename=PGP.sig content-transfer-encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Darwin) iEYEARECAAYFAknUqFcACgkQfD8M/ASTygKKNQCaA/lebd2rFgNQy1uQx6NEstcI bZcAn324/hwozWdEHbkT/B4LNG50pdt6 =8a0V -----END PGP SIGNATURE----- --Apple-Mail-1-520774333--