Date: Wed, 8 Mar 2023 21:24:08 +0100 From: Joerg Wunsch <j@uriah.heep.sax.de> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 175a584e501e - main - usb: dwc3: add <sys/mutex.h> Message-ID: <ZAju6PJHo5OlD9tE@uriah.heep.sax.de> In-Reply-To: <CACNAnaHC0nM%2BsggOjw7PA_zZOMPN8Tyy4u-L2kJnQMK_OMzxUg@mail.gmail.com> References: <202303082001.328K1iMn005869@gitrepo.freebsd.org> <CACNAnaHC0nM%2BsggOjw7PA_zZOMPN8Tyy4u-L2kJnQMK_OMzxUg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
As Kyle Evans wrote: > > Commit 5e54bb1ea9e90 added USB_BUS_LOCK/USB_BUS_UNLOCK. They, in > > consequence, require mutexes so <sys/mutex.h> is needed. > > Whoops, thanks! You're welcome. I'm just trying to compile a current kernel on a RockPi 4 (arm64), and it broke. While the reason for this one was rather obvious, the second breakage though is more of a mystery to me: sys/dev/dpaa2/dpaa2_mc.c fails to compile since LA_UNLOCKED is undefined. This is aliased to MA_NOTOWNED in <sys/mutex.h>. Sure, I can get it to compile by adding <sys/lock.h> to that file, but I don't see why it could ever compile at all. OTOH, wouldn't it make sense that <sys/mutex.h> itself included <sys/lock.h>? -- cheers, Joerg .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ Never trust an operating system you don't have sources for. ;-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZAju6PJHo5OlD9tE>