From owner-freebsd-hackers@FreeBSD.ORG Mon Oct 12 10:52:06 2009 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED501106568D for ; Mon, 12 Oct 2009 10:52:06 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id A2CE18FC08 for ; Mon, 12 Oct 2009 10:52:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 7CFBF14D9854; Mon, 12 Oct 2009 12:52:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at example.com Received: from server.mypc.hu ([127.0.0.1]) by localhost (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mA64p0jtXCE0; Mon, 12 Oct 2009 12:52:01 +0200 (CEST) Received: from [192.168.1.105] (catv-89-132-179-104.catv.broadband.hu [89.132.179.104]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id AE6A514D9853; Mon, 12 Oct 2009 12:52:01 +0200 (CEST) Message-ID: <4AD30A4B.7060409@FreeBSD.org> Date: Mon, 12 Oct 2009 12:51:55 +0200 From: Gabor Kovesdan User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <20091011145021.GG36937@acme.spoerlein.net> <20091011170918.GU71731@hoeg.nl> <4AD2FD6E.8090208@FreeBSD.org> <8663aksy43.fsf@ds4.des.no> In-Reply-To: <8663aksy43.fsf@ds4.des.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: Ed Schouten , FreeBSD Hackers Subject: Re: RFC: Big Makefile patch for WARNS settings X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2009 10:52:07 -0000 Dag-Erling Smørgrav escribió: > Gabor Kovesdan writes: > >> What I noticed is that the patch sets WARNS?=0 for a lot of utilities, >> which actually have higher WARNS-compliance. >> > > WARNS level 0 is the current default. All Ulrich's patch does is > reverse the logic so that WARNS is 6 by default and anything that didn't > already set WARNS explicitly sets it to 0, so the actual value of WARNS > in each Makefile is the same as before. This is orthogonal to actually > fixing whatever doesn't currently build at a higher WARNS level. > Yep, I understand that but what I'm saying is that once we are dealing with such a big patch, it would be nice to elaborate the highest WARNS level of each utility and set them accordingly, which doesn't require too much extra effort as opposed to making all of them WARNS=6 compliant. -- Gabor Kovesdan FreeBSD Volunteer EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org