Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Jul 2006 17:53:32 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 101483 for review
Message-ID:  <200607131753.k6DHrWLq056676@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=101483

Change 101483 by jhb@jhb_mutex on 2006/07/13 17:53:11

	Move free() of sa out of kern_connect().

Affected files ...

.. //depot/projects/smpng/sys/compat/linux/linux_socket.c#34 edit
.. //depot/projects/smpng/sys/kern/uipc_syscalls.c#89 edit

Differences ...

==== //depot/projects/smpng/sys/compat/linux/linux_socket.c#34 (text+ko) ====

@@ -640,6 +640,7 @@
 		return (error);
 
 	error = kern_connect(td, linux_args.s, sa);
+	free(sa, M_SONAME);
 	if (error != EISCONN)
 		return (error);
 

==== //depot/projects/smpng/sys/kern/uipc_syscalls.c#89 (text+ko) ====

@@ -535,7 +535,9 @@
 	if (error)
 		return (error);
 
-	return (kern_connect(td, uap->s, sa));
+	error = kern_connect(td, uap->s, sa);
+	free(sa, M_SONAME);
+	return (error);
 }
 
 
@@ -597,7 +599,6 @@
 	fdrop(fp, td);
 done2:
 	NET_UNLOCK_GIANT();
-	FREE(sa, M_SONAME);
 	return (error);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607131753.k6DHrWLq056676>