From owner-freebsd-current Wed Dec 13 19:35:20 1995 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id TAA26429 for current-outgoing; Wed, 13 Dec 1995 19:35:20 -0800 (PST) Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id TAA26421 for ; Wed, 13 Dec 1995 19:35:14 -0800 (PST) Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id UAA00876; Wed, 13 Dec 1995 20:33:21 -0700 From: Terry Lambert Message-Id: <199512140333.UAA00876@phaeton.artisoft.com> Subject: Re: VOP_READIR revisited To: davidg@root.com Date: Wed, 13 Dec 1995 20:33:21 -0700 (MST) Cc: terry@lambert.org, current@FreeBSD.org In-Reply-To: <199512140224.SAA00219@corbin.Root.COM> from "David Greenman" at Dec 13, 95 06:24:51 pm X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-current@FreeBSD.org Precedence: bulk > >I believe that it also resolves all the outstanding "cookie" issues > >cleanly, without unduly complicating the interfaces (in fact, UFS > >complication is decreased slightly and VOP_READDIR in msdosfs, cd9660fs, > >hpfs, ntfs, etc. becomes vastly *less* complicated for NFS exportable > >versions of the file systems). > > Cleanly??? Your proposal sounds like total kludgeware to me. So you basically think passing around a buffer pointer instead of a buffer, and converting it in the copyout case is a more of a kludge than copying to a local buffer and maintaining malloc'ed arrays of cookies at every stacked FS layer, the syscall, and NFS server export code. I must be missing something that is obvious to you. Please enlighten us. Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.