From owner-freebsd-current@FreeBSD.ORG  Thu Feb 19 19:32:22 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B83F81065714
	for <freebsd-current@FreeBSD.org>; Thu, 19 Feb 2009 19:32:22 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from sippysoft.com (gk1.360sip.com [72.236.70.240])
	by mx1.freebsd.org (Postfix) with ESMTP id 82F018FC0C
	for <freebsd-current@FreeBSD.org>; Thu, 19 Feb 2009 19:32:22 +0000 (UTC)
	(envelope-from sobomax@FreeBSD.org)
Received: from [192.168.1.38] (S0106001372fd1e07.vs.shawcable.net
	[70.71.171.106]) (authenticated bits=0)
	by sippysoft.com (8.13.8/8.13.8) with ESMTP id n1JJWJ62023079
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 19 Feb 2009 11:32:19 -0800 (PST)
	(envelope-from sobomax@FreeBSD.org)
Message-ID: <499DB399.4000604@FreeBSD.org>
Date: Thu, 19 Feb 2009 11:31:37 -0800
From: Maxim Sobolev <sobomax@FreeBSD.org>
Organization: Sippy Software, Inc.
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: hartzell@alerce.com
References: <18845.41728.753753.864779@almost.alerce.com>
In-Reply-To: <18845.41728.753753.864779@almost.alerce.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@FreeBSD.org
Subject: Re: help generating good id string for ATA id fix (Via VB8001)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Feb 2009 19:32:23 -0000

George Hartzell wrote:
> I have a Via VB8001 running -CURRENT.  The disk controllers aren't
> recognized and end up running in UDMA33.
> 
> The following patches to things under /usr/src/sys/dev/ata recognize
> my drives as SATA300.
> 
> I don't know how to figure out what id strings to use though,
> everything I've found about the board claims that the chip is a 8237S,
> which is already used.  Clearly calling it the GH is a hack.
> 
> How can I track down the correct info so that I can submit a useful
> PR?

Why does it matter so much? Call it ATA_VIA8237S_1 or ATA_VIA8237S_5372 
for example, this is definitely not the first time in history when 
vendor use different PCI Id for the different silicon revisions of the 
same part.

-Maxim