Date: Wed, 24 Jan 2001 11:18:50 -0800 From: David Greenman <dg@root.com> To: Luigi Rizzo <rizzo@aciri.org> Cc: net@FreeBSD.ORG Subject: Re: dubious code in ip_output() ? Message-ID: <200101241918.LAA23469@implode.root.com> In-Reply-To: Your message of "Wed, 24 Jan 2001 10:43:20 PST." <200101241843.f0OIhKQ09772@iguana.aciri.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>you are absolutely right that the code was correct at the time
>it was committed -- i think i tried to mention this.
>
>The question is where to move it now. Because it seems to be only
>necessary when we have fragmentation, perhaps the correct place is
>somewhere near the place where fragments are created (around line
>830 in 4.2):
>
> len = (ifp->if_mtu - hlen) &~ 7;
> if (len < 8) {
> error = EMSGSIZE;
> goto bad;
> }
>---> move check here <----
> /*
> * if the interface will not calculate checksums on
> * fragmented packets, then do it here.
> */
>
>so we get as much error reports as possible -- what do you think ?
If it works there, then that's fine by me.
-DG
David Greenman
Co-founder, The FreeBSD Project - http://www.freebsd.org
President, TeraSolutions, Inc. - http://www.terasolutions.com
Pave the road of life with opportunities.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101241918.LAA23469>