From owner-freebsd-fs@FreeBSD.ORG Mon Sep 13 05:01:55 2010 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B8349106566B for ; Mon, 13 Sep 2010 05:01:55 +0000 (UTC) (envelope-from james@jrv.org) Received: from mail.jrv.org (adsl-70-243-84-13.dsl.austtx.swbell.net [70.243.84.13]) by mx1.freebsd.org (Postfix) with ESMTP id 279CD8FC08 for ; Mon, 13 Sep 2010 05:01:54 +0000 (UTC) Received: from kremvax.housenet.jrv (kremvax.housenet.jrv [192.168.3.124]) by mail.jrv.org (8.14.3/8.14.3) with ESMTP id o8D4Ej33038971; Sun, 12 Sep 2010 23:14:45 -0500 (CDT) (envelope-from james@jrv.org) Authentication-Results: mail.jrv.org; domainkeys=pass (testing) header.from=james@jrv.org DomainKey-Signature: a=rsa-sha1; s=enigma; d=jrv.org; c=nofws; q=dns; h=message-id:date:from:user-agent:mime-version:to:cc:subject: references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=gDbZM3m4xmSAxwG0hjmC1mWpQdD9VXX4qKZGx1OrDb4xF1IqetElR/EXPYVky8ZZg /rTxdMIMWBjztOFBQkHEun5FUyuAW3KhE52cJV4BObfqQAJUY8988bf+qajq1xROQSO KjjEx1HxFhdTCG910Ss1KYd0vK5cucZ+VRU1OfQ= Message-ID: <4C8DA535.7050007@jrv.org> Date: Sun, 12 Sep 2010 23:14:45 -0500 From: "James R. Van Artsdalen" User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <20100831215915.GE1932@garage.freebsd.pl> In-Reply-To: <20100831215915.GE1932@garage.freebsd.pl> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@FreeBSD.org Subject: ZFS v28: ZFS recv abort X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2010 05:01:55 -0000 amd64, SVN 212080 with pjd's original v28 patch /sbin/zfs aborts receiving an incrementing stream. bigback:/root# zfs send -R -I @then bigtex@now | ssh kraken /sbin/zfs recv -dvF bigz Assertion failed: (!clp->cl_alldependents), file /usr/src/cddl/lib/libzfs/../../../cddl/contrib/opensolaris/lib/libzfs/common/libzfs_changelist.c, line 470. (the error message is from receiving system kraken) At the failing ASSERT(!clp->cl_alldependents) clp points to (gdb) p * (prop_changelist_t *) data $2 = {cl_prop = ZFS_PROP_MOUNTPOINT, cl_realprop = ZFS_PROP_NAME, cl_shareprop = ZFS_PROP_TYPE, cl_pool = 0x8018a8400, cl_list = 0x802243c50, cl_waslegacy = B_FALSE, cl_allchildren = B_FALSE, \ cl_alldependents = B_TRUE, cl_mflags = 524288, cl_gflags = 0, cl_haszonedchild = B_FALSE, cl_sorted = B_FALSE} One level up in parent function zfs_iter_dependents() zhp points to (gdb) p *zhp $3 = {zfs_hdl = 0x801810800, zpool_hdl = 0x801892140, zfs_name = "bigz/recv-2818-1", '\0' , zfs_type = ZFS_TYPE_FILESYSTEM, zfs_head_type = ZFS_TYPE_FILESYSTEM, zfs_dmustats\ = {dds_num_clones = 0, dds_creation_txg = 111554, dds_guid = 10368215686395422194, dds_type = DMU_OST_ZFS, dds_is_snapshot = 0 '\0', dds_inconsistent = 0 '\0', dds_origin = '\0' }, zfs_props = 0x801831040, zfs_user_props = 0x8018310c0, zfs_recvd_props = 0x0, zfs_mntcheck = B_FALSE, zfs_mntopts = 0x0, zfs_props_table = 0x0} I'm guessing that the filesystem was renamed, hence the "bigz/recv-2818-1" pool/dataset designation. Or perhaps a prior recv didn't properly change a temporary pool/recv-* dataset name back to the right name after that prior recv, causing the next recv to fail.