Date: 3 Jun 2003 23:10:18 -0000 From: Sergei Kolobov <sergei@kolobov.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/52917: [PATCH] bsd.port.mk: update default value of CONFIGURE_TARGET Message-ID: <20030603231018.81094.qmail@kolobov.com> Resent-Message-ID: <200306032320.h53NK1v4081668@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 52917
>Category: ports
>Synopsis: [PATCH] bsd.port.mk: update default value of CONFIGURE_TARGET
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Jun 03 16:20:00 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator: Sergei Kolobov
>Release: FreeBSD 5.1-BETA i386
>Organization:
>Environment:
System: FreeBSD elf.chetwood.ru 5.1-BETA FreeBSD 5.1-BETA #0: Mon May 26 00:30:25 MSD 2003
>Description:
Recent autoconf (2.5x) produces configure scripts which do not like our current
default value of CONFIGURE_TARGET variable. In the recent versions of
configure, it has to be passed as --build=... argument.
Thus, 477 ports currently redefine CONFIGURE_TARGET to silence the configure
warning. (and I am sure that some more ports just ignore this warning).
Since more and more software packages are updated to use autoconf 2.5x, this
quickly becomes a very common situation and it makes sense to deal with it by
change the default value of CONFIGURE_TARGET (see patch below).
Note: quick testing shows that this change does NOT break configure scripts
produced by older (2.13) versions of autoconf. In addition to that, those ports
that truly require the old value of CONFIGURE_TARGET could define it in their
Makefile. I estimate that only few ports (if any at all) will need that.
On the other hand, the majority of the ports will benefit from the updated
default value.
>How-To-Repeat:
>Fix:
--- configure-target.patch begins here ---
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.451
diff -u -r1.451 bsd.port.mk
--- bsd.port.mk 26 May 2003 20:59:12 -0000 1.451
+++ bsd.port.mk 3 Jun 2003 22:57:00 -0000
@@ -608,8 +608,8 @@
# CONFIGURE_SCRIPT - Name of configure script, relative to ${CONFIGURE_WRKSRC}
# (default: "Makefile.PL" if PERL_CONFIGURE is set,
# "configure" otherwise).
-# CONFIGURE_TARGET - The name of target to call when GNU_CONFIGURE is
-# defined (default: ${MACHINE_ARCH}-portbld-freebsd${OSREL}).
+# CONFIGURE_TARGET - The name of target to call when GNU_CONFIGURE is defined
+# (default: --build=${MACHINE_ARCH}-portbld-freebsd${OSREL}).
# CONFIGURE_ARGS - Pass these args to configure if ${HAS_CONFIGURE} is set
# (default: "--prefix=${PREFIX} ${CONFIGURE_TARGET}" if
# GNU_CONFIGURE is set, "CC=${CC} CCFLAGS=${CFLAGS}
@@ -2124,7 +2124,7 @@
.endif
CONFIGURE_SCRIPT?= configure
-CONFIGURE_TARGET?= ${MACHINE_ARCH}-portbld-freebsd${OSREL}
+CONFIGURE_TARGET?= --build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
CONFIGURE_LOG?= config.log
.if defined(GNU_CONFIGURE)
--- configure-target.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030603231018.81094.qmail>