From owner-freebsd-current@FreeBSD.ORG Fri May 21 00:41:39 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5C7916A4CE for ; Fri, 21 May 2004 00:41:39 -0700 (PDT) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id BD89443D1D for ; Fri, 21 May 2004 00:41:39 -0700 (PDT) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.9p1/8.12.8) with ESMTP id i4L7fQgd058622; Fri, 21 May 2004 00:41:26 -0700 (PDT) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id i4L7fQT3058621; Fri, 21 May 2004 00:41:26 -0700 (PDT) (envelope-from rizzo) Date: Fri, 21 May 2004 00:41:26 -0700 From: Luigi Rizzo To: Kris Kennaway Message-ID: <20040521004126.B43973@xorpc.icir.org> References: <20040504200316.GK19436@xor.obsecurity.org> <20040504133555.A69126@xorpc.icir.org> <20040521055535.GA43894@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20040521055535.GA43894@xor.obsecurity.org>; from kris@obsecurity.org on Thu, May 20, 2004 at 10:55:35PM -0700 cc: current@freebsd.org Subject: Re: wmnet-1.2 broken by if_poll_slowq X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2004 07:41:40 -0000 On Thu, May 20, 2004 at 10:55:35PM -0700, Kris Kennaway wrote: > On Tue, May 04, 2004 at 01:35:55PM -0700, Luigi Rizzo wrote: > > On Tue, May 04, 2004 at 01:03:16PM -0700, Kris Kennaway wrote: > > > Can whoever made this change please develop a patch for the port? > > > > looking at the code, i would just compile it with -DNDEBUG > > Alternatively, this one should work (beware of whitespace, > > i cut&pasted...) > > Is this patch also appropriate for 4.x? yes . There was no point in zeroing those fields, anyways. The program does not use them. cheers luigi > Kris > > > > > cheers > > luigi > > > > luigi# diff -ubwr if.c.orig if.c > > --- if.c.orig Tue May 4 22:37:31 2004 > > +++ if.c Tue May 4 22:39:56 2004 > > @@ -186,7 +186,6 @@ > > #endif > > d.if_bpf = 0; > > d.if_linkmib = 0; > > - d.if_poll_slowq = 0; > > #endif > > c = a; > > return &d; > > > > > Kris > > > > > > ----- Forwarded message from User Ports-i386 ----- > > > > > > X-Original-To: kkenn@localhost > > > Delivered-To: kkenn@localhost.obsecurity.org > > > Delivered-To: kris@freebsd.org > > > Date: Tue, 4 May 2004 16:57:00 GMT > > > From: User Ports-i386 > > > To: kris@FreeBSD.org > > > Subject: wmnet-1.2 failed on i386 5 > > > X-UIDL: \mP!!4(<"!mej!!H^p"! > > > X-Bogosity: No, tests=bogofilter, spamicity=0.000000, version=0.17.5 > > > > > > building wmnet-1.2 on gohan11 > > > in directory /x/tmp/5/chroot/12473 > > > maintained by: ports@FreeBSD.org > > > build started at Tue May 4 16:55:21 GMT 2004 > > > add_pkg > > > ================================================================ > > > ======================================== > > > ===> Vulnerability check disabled > > > >> wmnet-1.2.tar.gz doesn't seem to exist in /tmp/distfiles/. > > > >> Attempting to fetch from ftp://ftp-master.freebsd.org/pub/FreeBSD/ports/distfiles//. > > > wmnet-1.2.tar.gz 19 kB 1011 kBps > > > >> Checksum OK for wmnet-1.2.tar.gz. > > > ================================================================ > > > ======================================== > > > add_pkg > > > ===> Vulnerability check disabled > > > ===> Extracting for wmnet-1.2 > > > >> Checksum OK for wmnet-1.2.tar.gz. > > > ================================================================ > > > ======================================== > > > add_pkg > > > ===> Patching for wmnet-1.2 > > > ===> Applying FreeBSD patches for wmnet-1.2 > > > ================================================================ > > > ======================================== > > > add_pkg XFree86-libraries-4.3.0_7.tbz expat-1.95.7.tbz fontconfig-2.2.2,1.tbz freetype2-2.1.7_3.tbz imake-4.3.0_2.tbz perl-5.8.2_5.tbz pkgconfig-0.15.0_1.tbz > > > adding dependencies > > > pkg_add XFree86-libraries-4.3.0_7.tbz > > > Running fc-cache to build fontconfig cache... > > > fc-cache: "/usr/X11R6/lib/X11/fonts": caching, 0 fonts, 13 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/100dpi": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/75dpi": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/CID": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/PEX": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/Speedo": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/TTF": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/Type1": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/cyrillic": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/encodings": caching, 0 fonts, 1 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/encodings/large": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/latin2": caching, 0 fonts, 2 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/latin2/100dpi": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/latin2/75dpi": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/local": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/misc": caching, 0 fonts, 0 dirs > > > fc-cache: "/usr/X11R6/lib/X11/fonts/util": caching, 0 fonts, 0 dirs > > > fc-cache: "/root/.fonts": skipping, no such directory > > > fc-cache: succeeded > > > pkg_add expat-1.95.7.tbz > > > skipping expat-1.95.7, already added > > > pkg_add fontconfig-2.2.2,1.tbz > > > skipping fontconfig-2.2.2,1, already added > > > pkg_add freetype2-2.1.7_3.tbz > > > skipping freetype2-2.1.7_3, already added > > > pkg_add imake-4.3.0_2.tbz > > > skipping imake-4.3.0_2, already added > > > pkg_add perl-5.8.2_5.tbz > > > skipping perl-5.8.2_5, already added > > > pkg_add pkgconfig-0.15.0_1.tbz > > > skipping pkgconfig-0.15.0_1, already added > > > ===> wmnet-1.2 depends on shared library: X11.6 - found > > > ===> Configuring for wmnet-1.2 > > > ===> Building for wmnet-1.2 > > > cc -c -O -pipe -g -Wall -I/usr/X11R6/include main.c -o main.o > > > cc -c -O -pipe -g -Wall -I/usr/X11R6/include if.c -o if.o > > > if.c: In function `dereference': > > > if.c:201: error: structure has no member named `if_poll_slowq' > > > *** Error code 1 > > > > > > Stop in /tmp/a/ports/net/wmnet/work/wmnet-1.2. > > > *** Error code 1 > > > > > > Stop in /a/ports/net/wmnet. > > > ================================================================ > > > build ended at Tue May 4 16:56:57 GMT 2004 > > > > > > > > > ----- End forwarded message ----- > > > > > >