From owner-cvs-all Fri May 5 19:44:55 2000 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 3B15237B5BE; Fri, 5 May 2000 19:44:48 -0700 (PDT) (envelope-from kris@FreeBSD.org) Received: from localhost (kris@localhost) by freefall.freebsd.org (8.9.3/8.9.2) with ESMTP id TAA23076; Fri, 5 May 2000 19:44:48 -0700 (PDT) (envelope-from kris@FreeBSD.org) X-Authentication-Warning: freefall.freebsd.org: kris owned process doing -bs Date: Fri, 5 May 2000 19:44:48 -0700 (PDT) From: Kris Kennaway To: Alexander Langer Cc: "Jordan K. Hubbard" , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libftpio ftpio.c In-Reply-To: <20000505161148.A34126@cichlids.cichlids.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, 5 May 2000, Alexander Langer wrote: > > > Make FTP_PASSIVE_MODE check more specific. > > > Suggested by: Eric D. Futch > > Thanks, you broke it. > > Ok. Analyzed: > > FTP_PASSIVE_MODE=yes doesn't work now, maybe you want to add > two paranthesis and || !strcmp(..., "yes", 3) This change looks like a violation of POLA - historically, we have never tested most "feature activation" variables for what they contain, only whether they exist. Exceptions are things like USA_RESIDENT which must be set to a defined value (YES or NO), but for the majority of variables you can't set USE_SOMETHING=no and expect it to do what the english interpretation of the statement would suggest. If we're going to change, it should be to recognise certain negative values so that "FTP_PASSIVE_MODE=damnright" still works as it used to, but people can do "FTP_PASSIVE_MODE=no" or "NO" to disable it. Kris ---- In God we Trust -- all others must submit an X.509 certificate. -- Charles Forsythe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message