From owner-cvs-all@FreeBSD.ORG  Tue Aug  2 23:23:26 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CDE8A16A41F;
	Tue,  2 Aug 2005 23:23:26 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9F2A543D48;
	Tue,  2 Aug 2005 23:23:26 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j72NNQdf029725;
	Tue, 2 Aug 2005 23:23:26 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j72NNQrJ029724;
	Tue, 2 Aug 2005 23:23:26 GMT (envelope-from rwatson)
Message-Id: <200508022323.j72NNQrJ029724@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Tue, 2 Aug 2005 23:23:26 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/net if.c if_var.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Aug 2005 23:23:27 -0000

rwatson     2005-08-02 23:23:26 UTC

  FreeBSD src repository

  Modified files:
    sys/net              if.c if_var.h 
  Log:
  Protect link layer network interface multicast address list manipulation
  using ifp->if_addr_mtx:
  
  - Initialize if_addr_mtx when ifnet is initialized.
  
  - Destroy if_addr_mtx when ifnet is torn down.
  
  - Rename ifmaof_ifpforaddr() to if_findmulti(); assert if_addr_mtx.
    Staticize.
  
  - Extract ifmultiaddr allocation and initialization into if_allocmulti();
    accept a 'mflags' argument to indicate whether or not sleeping is
    permitted.  This centralizes error handling and address duplication.
  
  - Extract ifmultiaddr tear-down and deallocation in if_freemulti().
  
  - Re-structure if_addmulti() to hold if_addr_mtx around manipulation of
    the ifnet multicast address list and reference count manipulation.
    Make use of non-sleeping allocations.  Annotate the fact that we only
    generate routing socket events for explicit address addition, not
    implicit link layer address addition.
  
  - Re-structure if_delmulti() to hold if_addr_mtx around manipulation of
    the ifnet multicast address list and reference count manipulation.
    Annotate the lack of a routing socket event for implicit link layer
    address removal.
  
  - De-spl all and sundry.
  
  Problem reported by:    Ed Maste <emaste at phaedrus dot sandvine dot ca>
  MFC after:              1 week
  
  Revision  Changes    Path
  1.239     +208 -119  src/sys/net/if.c
  1.101     +0 -1      src/sys/net/if_var.h