From owner-freebsd-current Wed Feb 26 20:10:40 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BCCF37B401 for ; Wed, 26 Feb 2003 20:10:38 -0800 (PST) Received: from postino5.prima.com.ar (postino5.prima.com.ar [200.42.0.188]) by mx1.FreeBSD.org (Postfix) with SMTP id D1CDC43FDF for ; Wed, 26 Feb 2003 20:10:36 -0800 (PST) (envelope-from luismzuccolo@yahoo.com.ar) Received: (qmail 37314 invoked from network); 27 Feb 2003 04:10:34 -0000 Received: from dsl-200-42-141-176.prima.net.ar (HELO 192.168.0.2) (200.42.141.176) by postino5.prima.com.ar with SMTP; 27 Feb 2003 04:10:34 -0000 From: "Luis M. Zuccolo" To: Maxime Henrion , Jake Burkholder Subject: Re: patch for the nVidia driver and -CURRENT Date: Thu, 27 Feb 2003 04:11:05 -0300 User-Agent: KMail/1.5 Cc: Morten Rodal , current@FreeBSD.ORG References: <20030225182809.GA18565@elvis.mu.org> <20030226001542.A42311@locore.ca> <20030226110113.GE18565@elvis.mu.org> In-Reply-To: <20030226110113.GE18565@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200302270411.06281.luismzuccolo@yahoo.com.ar> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hello, I'm interested in applying this patch, because I've never done such precedure. Is anybody able to explane me, step by step, what should I do? Thanks in advance. On Wednesday 26 February 2003 08:01, Maxime Henrion wrote: > Jake Burkholder wrote: > > Apparently, On Tue, Feb 25, 2003 at 10:49:16PM +0100, > > Maxime Henrion said words to the effect of; > > > > > Morten Rodal wrote: > > > > On Tue, Feb 25, 2003 at 07:28:09PM +0100, Maxime Henrion wrote: > > > > [snip a lot of the patch] > > > > > > > > > @@ -1431,7 +1442,8 @@ > > > > > SLIST_FOREACH(at, &sc->alloc_list, list) { > > > > > if (offset >= at->address && > > > > > offset < at->address + at->size) > > > > > - return atop(vtophys(offset)); > > > > > + *paddr = vtophys(offset); > > > > > + return 0; > > > > > } > > > > > > > > > > return -1; > > > > > > > > Should the function return 0 even if the if (offset..) fails? I have > > > > no clue about the nvidia kernel driver (or kernel stuff at all) but > > > > it seems to me that the only way the function can return -1 is if the > > > > list is empty. > > > > > > And this is consistant with what the code was doing before. This > > > change is not a functional change, it's just a necessary update due to > > > API changes. > > > > I think he's referring to missing braces around the if which was changed > > from 1 statement to 2. > > Damnit. I've updated the patch at : > http://mu.org/~mux/patches/nvidia.patch > > I've also added the removal of the #error in this patch, since people > have been asking me about it. > > Cheers, > Maxime > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message