From nobody Thu Sep 18 16:18:06 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cSLQl1n87z67dF7; Thu, 18 Sep 2025 16:18:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cSLQk74Hhz45xd; Thu, 18 Sep 2025 16:18:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758212287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Co/JdMk7EPhaHHoNz1teoDFV24gCfQKb3ungT43Mhm0=; b=sLVGMTwD+yur9HRt4/dxUCmVos5zEt6BUC3ruGv7RbrrkWjKFQO8bGpCP18hIHQ539twhx awEe5gqfx7085vHvb/Lf3vzHi5cOkzc5sNqlH7m/DfowuLPLPoGRkxVqrAxvfFXo4zdWDc spYsb3csLfDFTKbdJlTVb4tq9ll7o1uHu93o4Q+yaWXyOItsU+Nstuw2KKOSrZCjxlCZNA aN9gXwUKHNSmLl3VSzjSz+hnhy7eYyn2hbcO+O7BaAao8HSTzeuXRTe2tzqQtOS2SCwWPv TiYDR5YlUrx+dPYMDxcOh3dB+kligu8ozT1xwEvBjkT5iZg5wMPC4BF6VdHxeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758212287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Co/JdMk7EPhaHHoNz1teoDFV24gCfQKb3ungT43Mhm0=; b=EnZQlXaxCKFTYxbmHUyiLyCYYzm31JKsH55NEqnKUC34K531hEgfpC0i0dj5ah/dPn8I9e LJ9fYe7DFZONpJ0LjwJlXA4EDhNxHpCT98uKiUj2SXtuDCClmb1dqSdGuz6VYe3Sfv6xJV d3KVo9A5FTtBhGqlx/6YtvL0BZbJqXrPYMQVoYN40gqOnNgbvoUN/JyaQ7OuaX847tx9ig 9HdE1RudkBVs/bZJJdTFxvwXDhoVNokpEJDplGDV1+crN384u7w3kjDSV3p/jv7IV6anRr sgW/6VNotEpOiBW1td1LQv23YtzyubbEgPUXmsjZ9/olwqHRbIXnF7+itdvzpQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758212287; a=rsa-sha256; cv=none; b=G061TSlryt8R2IbcJwzCaSzOhIendqUlejjJEY/LKKTXVxIDeeuhYO+84ooSkd9dgOjjO3 kXZrpMnR5TbKMiWeJdMcvbvD8rwDLVuA/o8/0Aac75wCsdZg0tYCf1UO6W+b9spKLNF4lT YLSBBGS4uIQ5JPb9951Ipm0pbXUrsikIUj2X/If4nCHzTK7jVyz1n9L91Qxz+/72tXDYY6 3LaIEdDkZtD50notPk2A0HVFu4fY/ZT0JpSTIxDd0VhAQOLjVYlu/Z0EsXb+fjCAAeoMmH rv+uAqpGNecT+/whLtasZ7l8EzT1OwHTVqydfpQIZ5aTgEJJt9XtyMLnEdmiMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cSLQk5YLJz39W; Thu, 18 Sep 2025 16:18:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58IGI6Hc050893; Thu, 18 Sep 2025 16:18:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58IGI6tY050890; Thu, 18 Sep 2025 16:18:06 GMT (envelope-from git) Date: Thu, 18 Sep 2025 16:18:06 GMT Message-Id: <202509181618.58IGI6tY050890@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 6fb046515ea6 - stable/15 - qlnxe: Report speeds in decimal format List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 6fb046515ea6005b3958e0c3220d0e6e630af292 Auto-Submitted: auto-generated The branch stable/15 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=6fb046515ea6005b3958e0c3220d0e6e630af292 commit 6fb046515ea6005b3958e0c3220d0e6e630af292 Author: Zhenlei Huang AuthorDate: 2025-09-09 10:04:55 +0000 Commit: Zhenlei Huang CommitDate: 2025-09-18 16:15:52 +0000 qlnxe: Report speeds in decimal format It is more natural to read the speed in decimal format than hexadecimal one. Spotted this while diagnosing PR 287445, ``` [__ecore_configure_pf_max_bandwidth:6864(qlnx-0)]Configured MAX bandwidth to be 000061a8 Mb/sec [__ecore_configure_pf_min_bandwidth:6922(qlnx-0)]Configured MIN bandwidth to be 750 Mb/sec ``` Reviewed by: kbowling MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D52376 (cherry picked from commit e1c5e043961ab3a5429a0c6e727265dfa819cf00) --- sys/dev/qlnx/qlnxe/ecore_dev.c | 6 +++--- sys/dev/qlnx/qlnxe/ecore_mcp.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/ecore_dev.c b/sys/dev/qlnx/qlnxe/ecore_dev.c index 6187ecdbc446..389a95a4164c 100644 --- a/sys/dev/qlnx/qlnxe/ecore_dev.c +++ b/sys/dev/qlnx/qlnxe/ecore_dev.c @@ -5268,7 +5268,7 @@ ecore_hw_get_nvm_info(struct ecore_hwfn *p_hwfn, } DP_VERBOSE(p_hwfn, ECORE_MSG_LINK, - "Read default link: Speed 0x%08x, Adv. Speed 0x%08x, AN: 0x%02x, PAUSE AN: 0x%02x EEE: %02x [%08x usec]\n", + "Read default link: Speed %u Mb/sec, Adv. Speeds 0x%08x, AN: 0x%02x, PAUSE AN: 0x%02x EEE: %02x [%u usec]\n", link->speed.forced_speed, link->speed.advertised_speeds, link->speed.autoneg, link->pause.autoneg, p_caps->default_eee, p_caps->eee_lpi_timer); @@ -6860,7 +6860,7 @@ int __ecore_configure_pf_max_bandwidth(struct ecore_hwfn *p_hwfn, p_hwfn->qm_info.pf_rl); DP_VERBOSE(p_hwfn, ECORE_MSG_LINK, - "Configured MAX bandwidth to be %08x Mb/sec\n", + "Configured MAX bandwidth to be %u Mb/sec\n", p_link->speed); return rc; @@ -6918,7 +6918,7 @@ int __ecore_configure_pf_min_bandwidth(struct ecore_hwfn *p_hwfn, rc = ecore_init_pf_wfq(p_hwfn, p_ptt, p_hwfn->rel_pf_id, min_bw); DP_VERBOSE(p_hwfn, ECORE_MSG_LINK, - "Configured MIN bandwidth to be %d Mb/sec\n", + "Configured MIN bandwidth to be %u Mb/sec\n", p_link->min_pf_rate); return rc; diff --git a/sys/dev/qlnx/qlnxe/ecore_mcp.c b/sys/dev/qlnx/qlnxe/ecore_mcp.c index ab14b1eb5186..6d1e5fe24d06 100644 --- a/sys/dev/qlnx/qlnxe/ecore_mcp.c +++ b/sys/dev/qlnx/qlnxe/ecore_mcp.c @@ -1638,7 +1638,7 @@ enum _ecore_status_t ecore_mcp_set_link(struct ecore_hwfn *p_hwfn, if (b_up) DP_VERBOSE(p_hwfn, ECORE_MSG_LINK, - "Configuring Link: Speed 0x%08x, Pause 0x%08x, adv_speed 0x%08x, loopback 0x%08x\n", + "Configuring Link: Speed %u Mb/sec, Pause 0x%08x, adv_speed 0x%08x, loopback 0x%08x\n", phy_cfg.speed, phy_cfg.pause, phy_cfg.adv_speed, phy_cfg.loopback_mode); else