From owner-svn-src-stable-7@FreeBSD.ORG Thu Dec 9 15:27:43 2010 Return-Path: Delivered-To: svn-src-stable-7@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF2F71065679; Thu, 9 Dec 2010 15:27:43 +0000 (UTC) (envelope-from brucec@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 9DDAB8FC17; Thu, 9 Dec 2010 15:27:43 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id oB9FRhvV042593; Thu, 9 Dec 2010 15:27:43 GMT (envelope-from brucec@svn.freebsd.org) Received: (from brucec@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id oB9FRh8k042590; Thu, 9 Dec 2010 15:27:43 GMT (envelope-from brucec@svn.freebsd.org) Message-Id: <201012091527.oB9FRh8k042590@svn.freebsd.org> From: Bruce Cran Date: Thu, 9 Dec 2010 15:27:43 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org X-SVN-Group: stable-7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r216327 - stable/7/usr.sbin/sysinstall X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2010 15:27:43 -0000 Author: brucec Date: Thu Dec 9 15:27:43 2010 New Revision: 216327 URL: http://svn.freebsd.org/changeset/base/216327 Log: MFC r216243: Ignore any failures with the "local" distribution since it's not present on release CDs and so will normally fail. installCommit() returns a DITEM_ value, not a Boolean. distExtractAll() returns a Boolean, not a DITEM_ value. Approved by: re (kensmith) Modified: stable/7/usr.sbin/sysinstall/dist.c stable/7/usr.sbin/sysinstall/install.c Directory Properties: stable/7/usr.sbin/sysinstall/ (props changed) Modified: stable/7/usr.sbin/sysinstall/dist.c ============================================================================== --- stable/7/usr.sbin/sysinstall/dist.c Thu Dec 9 15:26:38 2010 (r216326) +++ stable/7/usr.sbin/sysinstall/dist.c Thu Dec 9 15:27:43 2010 (r216327) @@ -781,6 +781,9 @@ distExtract(char *parent, Distribution * canceled = 1; status = FALSE; + } else { + // ignore any failures with DIST_LOCAL + status = TRUE; } } break; @@ -878,7 +881,7 @@ distExtractAll(dialogMenuItem *self) restorescr(w); if (extract_status == FALSE) - status = DITEM_FAILURE; + status = FALSE; return status; } Modified: stable/7/usr.sbin/sysinstall/install.c ============================================================================== --- stable/7/usr.sbin/sysinstall/install.c Thu Dec 9 15:26:38 2010 (r216326) +++ stable/7/usr.sbin/sysinstall/install.c Thu Dec 9 15:27:43 2010 (r216327) @@ -817,7 +817,7 @@ try_media: i = distExtractAll(self); if (i == FALSE) - return FALSE; + return DITEM_FAILURE; /* When running as init, *now* it's safe to grab the rc.foo vars */ installEnvironment();