From owner-svn-src-head@freebsd.org Fri Apr 14 19:49:53 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C360D3E5A1; Fri, 14 Apr 2017 19:49:53 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-yw0-x233.google.com (mail-yw0-x233.google.com [IPv6:2607:f8b0:4002:c05::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BF1C2698; Fri, 14 Apr 2017 19:49:52 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-yw0-x233.google.com with SMTP id l189so38612669ywb.0; Fri, 14 Apr 2017 12:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=C1FabYwjIqfc5ycgQxc1t6ytsKcmb59yVIMvFQN2zYg=; b=iHbvJixczuQSOLiho1pGnfFqsSsNCbAXSB3Pj8bj+xce7Uwbz3BftlvOZERJDNtoXr jMYb/VOIrF6pEonF5o2XxZM/oMwEUq3HCvFWi3bVH0+1W0n6GyKcLd/2xkQXvKdPw1cg GVOeH8B9L+qk/ar/LrS+juB0wVNNeEoh8ZkRxk7rrl7JHx1K2YhHafEIB52WZBYXdIHs CZR7qsSXJ7/zgnaQI5kIMX84SzwiHvhZazUW/U1SeDlPO9+UNd/E/PXgyr4KuPczu2kN LHWSqCDiX6ttmhEdsXjomswdUViDtAvX+UuvtTXwhKqB2dulESTy546T61v23n0JcQ2F I6BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=C1FabYwjIqfc5ycgQxc1t6ytsKcmb59yVIMvFQN2zYg=; b=XLGe9qTfe2oD5aF87hZF3VzbFH7Ugv2aRSOalt7ElFMhLKFlS59O2VjpiQHh0h6AHW KE4tylu0De6wbzMsDOMIE8gpvpXTIzS/ki+FpHP72KgVFbPTaYLy2b1bxNLvs7bWqZph 1tbgqOrfAhfapmQacxUj0sMuZ34j5UPO9Nz4Foj+RfB3MOIEb6W8mz22R/bGPUI2DP5H zPymraJ5QES/Ik68+26cRb873BhLYl//vZ46P5oGzPLgsfEMODq/5VRGBdWvLZbI9Cjd /+PwxdGQ9Npz7ZldIJKsHxBGf8+QLFvs/GWf5Fh/iF75KsIcsl94SllbrJOKBMz92Oqw ExGQ== X-Gm-Message-State: AN3rC/6dphNIufntR+PG+XzEZPM6y4+NCSwjyKgt1RTYaoiW8RdOXK/P Ih9llk7Cl1oteKxtRsT4HAQQ3biMFuk4 X-Received: by 10.129.154.203 with SMTP id r194mr7164595ywg.252.1492199391588; Fri, 14 Apr 2017 12:49:51 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.129.20.214 with HTTP; Fri, 14 Apr 2017 12:49:51 -0700 (PDT) In-Reply-To: <201704141941.v3EJfmCW003347@repo.freebsd.org> References: <201704141941.v3EJfmCW003347@repo.freebsd.org> From: Alan Somers Date: Fri, 14 Apr 2017 13:49:51 -0600 X-Google-Sender-Auth: nDfBDp64etuuyVaVZW4vpZRre8M Message-ID: Subject: Re: svn commit: r316938 - head/sbin/savecore To: Ngie Cooper Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 19:49:53 -0000 On Fri, Apr 14, 2017 at 1:41 PM, Ngie Cooper wrote: > Author: ngie > Date: Fri Apr 14 19:41:48 2017 > New Revision: 316938 > URL: https://svnweb.freebsd.org/changeset/base/316938 > > Log: > savecore: fix space calculation with respect to `minfree` in check_space(..) > > - Use strtoll(3) instead of atoi(3), because atoi(3) limits the > representable data to INT_MAX. Check the values received from > strtoll(3), trimming trailing whitespace off the end to maintain > POLA. > - Use `KiB` instead of `kB` when describing free space, total space, > etc. I am now fully aware of `KiB` being the IEC standard for 1024 > bytes and `kB` being the IEC standard for 1000 bytes. > - Store available number of KiB in `available` so it can be more > easily queried and compared to ensure that there are enough KiB to > store the dump image on disk. > - Print out the reserved space on disk, per `minfree`, so end-users > can troubleshoot why check_space(..) is reporting that there isn't > enough free space. > > MFC after: 7 weeks > Reviewed by: Anton Rang (earlier diff), cem (earlier diff) > Tested with: positive/negative cases (see review); make tinderbox > Sponsored by: Dell EMC Isilon > Differential Revision: D10379 The free space calculation is still uselessly conservative, because it doesn't account for the fact that core dumps will always be either spare or compressed. The result is that savecore will frequently refuse to save corefiles even when there's plenty of space. I proposed removing the space check altogether in https://reviews.freebsd.org/D2587. However, I agreed to wait until after the compressed core dump feature was merged, because then mostly accurate space checks will be possible. AFAIK the compressed core dump feature still hasn't been finished. -Alan