From owner-freebsd-usb@FreeBSD.ORG Tue Mar 1 08:46:36 2011 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A7CA8106566C for ; Tue, 1 Mar 2011 08:46:36 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe01.c2i.net [212.247.154.2]) by mx1.freebsd.org (Postfix) with ESMTP id 2A9B58FC08 for ; Tue, 1 Mar 2011 08:46:35 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=Vlw5OJcoxCC473z5moizI40ESYe+BpcMN2hU0iQoJwI= c=1 sm=1 a=Eg2Q673f0N8A:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=yyC9SVb8mdVzIATUaBgA:9 a=-hOtk3xNNKvrTnDU8bcA:7 a=Fp1op4voaMB62AIH1nTu19xdEzYA:4 a=wPNLvfGTeEIA:10 a=ldNr2bF7WF7wNYqEPK8A:9 a=5fxk4txBRpRQdeNizan7w8_kaj4A:4 a=i9M/sDlu2rpZ9XS819oYzg==:117 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mailfe01.swip.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 X-TFF-CGPSA-Version: 1.7 X-T2-CGPSA-Filter: Scanned Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe01.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 94674291; Tue, 01 Mar 2011 09:46:33 +0100 From: Hans Petter Selasky To: freebsd-usb@freebsd.org Date: Tue, 1 Mar 2011 09:46:14 +0100 User-Agent: KMail/1.13.5 (FreeBSD/8.2-PRERELEASE; KDE/4.4.5; amd64; ; ) References: <4D6C829F.6090709@telus.net> <51ED50BF-C3B2-42C5-8E8A-D88DCC266EF6@gsoft.com.au> <201103010933.39054.hselasky@c2i.net> In-Reply-To: <201103010933.39054.hselasky@c2i.net> X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5 %V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC( :AuzV9:.hESm-x4h240C`9=w MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_WJLbNEz4pztMtC9" Message-Id: <201103010946.14791.hselasky@c2i.net> Cc: Carl Subject: Re: why does ulpt depend on ucom? X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2011 08:46:36 -0000 --Boundary-00=_WJLbNEz4pztMtC9 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit On Tuesday 01 March 2011 09:33:38 Hans Petter Selasky wrote: > On Tuesday 01 March 2011 07:31:00 Daniel O'Connor wrote: > > On 01/03/2011, at 15:52, Carl wrote: > > > /usr/src/sys/conf/files causes the ucom driver to be compiled into the > > > kernel if ulpt is specified for inclusion. Why? ucom provides support > > > for USB tty. > > > > Looks like a bug, specifically the second to last line of > > /usr/src/sys/dev/usb/serial/ulpt.c > > You are right. > > > Also, I'm not really sure why ulpt.c is in the serial directory but that > > isn't a big issue. Please try the attached patch and report back. --HPS --Boundary-00=_WJLbNEz4pztMtC9 Content-Type: text/x-patch; charset="iso-8859-1"; name="ulpt_depend.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ulpt_depend.patch" === sys/dev/usb/serial/ulpt.c ================================================================== --- sys/dev/usb/serial/ulpt.c (revision 219105) +++ sys/dev/usb/serial/ulpt.c (local) @@ -743,5 +743,4 @@ DRIVER_MODULE(ulpt, uhub, ulpt_driver, ulpt_devclass, NULL, 0); MODULE_DEPEND(ulpt, usb, 1, 1, 1); -MODULE_DEPEND(ulpt, ucom, 1, 1, 1); MODULE_VERSION(ulpt, 1); === sys/conf/files ================================================================== --- sys/conf/files (revision 219105) +++ sys/conf/files (local) @@ -1874,7 +1874,7 @@ dev/usb/serial/uvscom.c optional uvscom dev/usb/serial/usb_serial.c optional ucom | u3g | uark | ubsa | ubser | \ uchcom | ucycom | ufoma | uftdi | \ - ugensa | uipaq | ulpt | umct | \ + ugensa | uipaq | umct | \ umodem | umoscom | uplcom | uslcom | \ uvisor | uvscom # --Boundary-00=_WJLbNEz4pztMtC9--