From owner-svn-src-all@freebsd.org Mon May 16 16:51:24 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09B4FB3D93B; Mon, 16 May 2016 16:51:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x234.google.com (mail-pa0-x234.google.com [IPv6:2607:f8b0:400e:c03::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D5254175E; Mon, 16 May 2016 16:51:23 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pa0-x234.google.com with SMTP id bt5so65983902pac.3; Mon, 16 May 2016 09:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=U3lrpGsz9Gf/OPArZWunX/04vdNPeRj1UcVfJqbJUMM=; b=OUCjG/CP9ZOXYDKqqySyF8w2WwJgbdjMPNM3/IsfdGkwtZPJw2pj7S3DBlKl0pXqwg LqK5nyHVldWIutpEb+aaOyiOLTnIexmKuPdTxT5JMvKN8h0/XPG3jtBLmX3u63DxN0kc 5dO5VtAewasQl/rOf97jy+wNHpenaJ4wPXJUhK0eI2W8XY1YdcobWRcpcfJbAClaRwwC stHBUpF8l3UwrNRB/hNp9WzCLSVezrue3y7yuoETqQrRa7sbwzgu+0FWLRwB+nA23A2N q3D/EVLfPJQR1eD2lY19UaGyJ3+erqP+B6PRN9QGp4pEc0SeWGgjpvfDcBXM26IA4pj6 IDiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=U3lrpGsz9Gf/OPArZWunX/04vdNPeRj1UcVfJqbJUMM=; b=EvrJAwWJhSIS1QcIt2EADwGNzzzIUns5g82kqK+j91Bx+LefW07Nrheh6SsaNhpmPq JFrbplTkp0KqkXPpNo0XaPuX6aODmfkczP5o6I6I/Tejye264n01pXWqQT/SxfO674W6 gGXiRwXPddgoYn6mjAFhXveNJY9QlDALA/iTBvZB9enz4dE3Mp2oEkNtYD/liZtCdTXv iK8SlPB3th7VOdSVQLkUm+wBKYDJ5yJEPpKb74aGyPEyqGBLKM42P0xW+vaQtUtlArWy H5fx1zWGjpD3kAwNdfEZXX+rdw8xlgscInmzgWLgFVCQaZ9D+MaZnQD8Wq61e7BCbLuA y1Wg== X-Gm-Message-State: AOPr4FVs0GWTr+IryHyBqqm4DigXNOIzdDHEPgmbyVHB/l8Z50jArwPNsmXWAjpCCs8MFw== X-Received: by 10.66.66.10 with SMTP id b10mr47127631pat.12.1463417483270; Mon, 16 May 2016 09:51:23 -0700 (PDT) Received: from [192.168.20.7] (c-73-97-222-46.hsd1.wa.comcast.net. [73.97.222.46]) by smtp.gmail.com with ESMTPSA id qb1sm48585984pac.44.2016.05.16.09.51.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 May 2016 09:51:22 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r299933 - in head/sys: compat/linuxkpi/common/include/linux sys From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <308052a8-f574-5725-f6d7-e395956ca78a@selasky.org> Date: Mon, 16 May 2016 09:51:22 -0700 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4049F31C-6F86-4284-B3A5-8A4640671E43@gmail.com> References: <201605160956.u4G9umAT025380@repo.freebsd.org> <222500EB-85C1-4FF7-ADB9-0BD71F55D835@gmail.com> <308052a8-f574-5725-f6d7-e395956ca78a@selasky.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 16:51:24 -0000 > On May 16, 2016, at 09:47, Hans Petter Selasky = wrote: >=20 > On 05/16/16 18:31, Ngie Cooper (yaneurabeya) wrote: >> Dumb question =E2=80=94 couldn=E2=80=99t we run the check without = locking Giant, then delete the child, e.g. >>=20 >> if (bsddev !=3D NULL) { >> mtx_lock(&Giant); >> device_delete_child(device_get_parent(bsddev), bsddev); >> mtx_unlock(&Giant); >> } >> put_device(dev); >=20 > I guess so. Does it make a difference for you? First off, how often does the bsddev =3D=3D NULL case occur? If it doesn=E2=80=99t occur often, doing this increases contention on = Giant unnecessarily=E2=80=A6 Thanks, -Ngie=