From owner-freebsd-current@FreeBSD.ORG Sun Dec 1 18:57:01 2013 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A255BD1A; Sun, 1 Dec 2013 18:57:01 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5CF8D1543; Sun, 1 Dec 2013 18:57:01 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::d491:85a3:d731:bb13] (unknown [IPv6:2001:7b8:3a7:0:d491:85a3:d731:bb13]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id D2E3E5C43; Sun, 1 Dec 2013 19:56:56 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_0D17A4BD-1640-4508-8E4E-7390E5410401"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: patch -p broken on HEAD? From: Dimitry Andric In-Reply-To: <529B7DE4.5030906@aldan.algebra.com> Date: Sun, 1 Dec 2013 19:56:34 +0100 Message-Id: <2D565D54-82B9-47DD-B52F-7C657D9129FC@FreeBSD.org> References: <201311301824.rAUIOg9S075512@beefy1.isc.freebsd.org> <529B7DE4.5030906@aldan.algebra.com> To: "Mikhail T." X-Mailer: Apple Mail (2.1822) Cc: pkg-fallout@FreeBSD.org, Current FreeBSD X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Dec 2013 18:57:01 -0000 --Apple-Mail=_0D17A4BD-1640-4508-8E4E-7390E5410401 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 01 Dec 2013, at 19:20, Mikhail T. wrote: > On 30.11.2013 13:24, pkg-fallout@FreeBSD.org wrote: >> =3D=3D=3D> Applying FreeBSD patches for xmdiary-3.0.3_3 >> removing the malloc.h includes >> /bin/sh /usr/ports/deskutils/xmdiary/scripts/nomalloc = /wrkdirs/usr/ports/deskutils/xmdiary/work/xmdiary-3.0.3 2>&1 > /dev/zero >> patch: option requires an argument -- p >> usage: patch [-bCcEeflNnRstuv] [-B backup-prefix] [-D symbol] [-d = directory] >> [-F max-fuzz] [-i patchfile] [-o out-file] [-p = strip-count] >> [-r rej-name] [-V t | nil | never] [-x number] [-z = backup-ext] >> [--posix] [origfile [patchfile]] >> patch > patch: option requires an argument -- p > It looks like the -p option can no longer be given to patch(1) by > itself. Is this deliberate? Thanks, I think so, yes. It was removed 10 years ago from OpenBSD's patch: http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/patch/patch.c#rev1.34 'Historically, patch would treat a bare -p as -p0. This contradicts POSIX and GNU patch has also removed this, so we will too. No objections on icb (no one even seemed to know about this "feature").' Just add -p0, and you should be fine. -Dimitry --Apple-Mail=_0D17A4BD-1640-4508-8E4E-7390E5410401 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iEYEARECAAYFAlKbhmoACgkQsF6jCi4glqNmzQCfcUMBv9RSb7Zikm+BapoZ0pGl v58Amwf4NaGFTK7GkDuemcae6rwcwrrp =2vNg -----END PGP SIGNATURE----- --Apple-Mail=_0D17A4BD-1640-4508-8E4E-7390E5410401--