From owner-svn-src-head@freebsd.org  Wed Apr 13 09:25:03 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42619B0E0B0;
 Wed, 13 Apr 2016 09:25:03 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0DFE71222;
 Wed, 13 Apr 2016 09:25:02 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 6C9B41FE028;
 Wed, 13 Apr 2016 11:24:59 +0200 (CEST)
Subject: Re: svn commit: r297913 - in head/sys/dev/hyperv: netvsc storvsc
To: Sepherosa Ziehau <sephe@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201604130920.u3D9KTVv071995@repo.freebsd.org>
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <570E112B.10207@selasky.org>
Date: Wed, 13 Apr 2016 11:28:11 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <201604130920.u3D9KTVv071995@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Apr 2016 09:25:03 -0000

On 04/13/16 11:20, Sepherosa Ziehau wrote:
>   	bzero(sc, sizeof(hn_softc_t));

Hi,

According to:

> https://svnweb.freebsd.org/base/head/sys/kern/subr_bus.c?revision=297776&view=markup#l2763

It is safe to assume that the memory you get is already zero'ed.

The additional bzero() in your attach routine seems redundant.

--HPS