From owner-freebsd-current@FreeBSD.ORG Thu Jun 26 16:45:58 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 618) id ECF8C37B401; Thu, 26 Jun 2003 16:45:58 -0700 (PDT) In-Reply-To: <200306270004.aa89273@salmon.maths.tcd.ie> from Ian Dowse at "Jun 27, 2003 00:04:52 am" To: iedowse@maths.tcd.ie (Ian Dowse) Date: Thu, 26 Jun 2003 16:45:58 -0700 (PDT) X-Mailer: ELM [version 2.4ME+ PL54 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20030626234558.ECF8C37B401@hub.freebsd.org> From: wpaul@FreeBSD.ORG (Bill Paul) cc: wpaul@FreeBSD.ORG cc: sos@spider.deepcore.dk cc: current@FreeBSD.ORG cc: imp@bsdimp.com Subject: Re: Heads up: checking in change to ata-card.c X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2003 23:45:59 -0000 > In message <20030626.131417.101814768.imp@bsdimp.com>, "M. Warner Losh" writes: > >Here's a better patch, basesd on wpaul's input. Bill, can you try it > >an see if it works for you? If so, i would be better to commit this > >one. If not, I'll work with you to fix it. > > FYI, I have a no-name ("PCMCIA"/"CD-ROM") drive that also requires > failure of the second IO range to be made non-fatal. How about just > deleting the `else' clause as in the patch below? It seems that > this can only affect CD-ROM drives that were otherwise not working, > so it should be fairly safe. This patch also tests good with my drive. -Bill -- ============================================================================= -Bill Paul (510) 749-2329 | Senior Engineer, Master of Unix-Fu wpaul@windriver.com | Wind River Systems ============================================================================= "If stupidity were a handicap, you'd have the best parking spot." ============================================================================= > Ian > > Index: ata-card.c > =================================================================== > RCS file: /dump/FreeBSD-CVS/src/sys/dev/ata/ata-card.c,v > retrieving revision 1.14 > diff -u -r1.14 ata-card.c > --- ata-card.c 17 Jun 2003 12:33:53 -0000 1.14 > +++ ata-card.c 26 Jun 2003 23:00:01 -0000 > @@ -131,10 +131,6 @@ > start + ATA_ALTOFFSET, ATA_ALTIOSIZE); > } > } > - else { > - bus_release_resource(dev, SYS_RES_IOPORT, rid, io); > - return ENXIO; > - } > > /* allocate the altport range */ > rid = ATA_ALTADDR_RID; > >