From owner-svn-ports-all@freebsd.org Mon Aug 12 17:47:46 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8923DBB25A; Mon, 12 Aug 2019 17:47:46 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 466jww73Rmz4fkj; Mon, 12 Aug 2019 17:47:44 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id xEQ0hWn6CSrVcxEQ1h1FSF; Mon, 12 Aug 2019 11:47:42 -0600 X-Authority-Analysis: v=2.3 cv=L5ZjvNb8 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=FmdZ9Uzk2mMA:10 a=6I5d2MoRAAAA:8 a=pGLkceISAAAA:8 a=YxBL1-UpAAAA:8 a=d6BQhbgN-I8NlfvVLa4A:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from 5CG5030TVK-N.esitwifi.local (S0106788a207e2972.gv.shawcable.net [70.66.154.233]) by spqr.komquats.com (Postfix) with ESMTPSA id B5229375; Mon, 12 Aug 2019 10:47:39 -0700 (PDT) Date: Mon, 12 Aug 2019 10:47:18 -0700 In-Reply-To: References: <201908121052.x7CAq001072686@repo.freebsd.org> <20190812135241.GA26036@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: svn commit: r508723 - head/net/ocserv To: Carlos Jacobo Puga Medina , Alexey Dokuchaev CC: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: Cy Schubert Message-ID: <9A853940-2D7C-4EA8-999E-AE0F81A90102@cschubert.com> X-CMAE-Envelope: MS4wfNZSsB2GaMlD7hem66GcFTDCb355eclPbWKfQZLcAN4BmbEDMXZ/sOUQyknCZUT/IiAZ+ypsSF4Hwj2/f7vXd6Su2AoaGMiVIil2ZGOWxp/3e3XM+ONw IKKOFiQOFH5YO6+k2eF3qsjvNX/BskCVx5WLNM9zQLAExhQ4v/GL2KHFHfp9qBeexkepfidtY1UaB+uxZ11AU3QgRENOYPnjsqddrThY+g3TlWT5La9igScD UAjbnYxEy4Tt6WMzPqCWE3sOcVp+bvxJn3mo17EE3AJ0y/MgQDmbTv6vrWjzrpfxhs1go32EjZrkWqkwvThBag== X-Rspamd-Queue-Id: 466jww73Rmz4fkj X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.137) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-5.40 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.948,0]; RCVD_IN_DNSWL_NONE(0.00)[137.136.59.64.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-2.35)[ip: (-6.03), ipnet: 64.59.128.0/20(-3.17), asn: 6327(-2.46), country: CA(-0.09)]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11, 233.154.66.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 17:47:46 -0000 On August 12, 2019 10:21:02 AM PDT, Carlos Jacobo Puga Medina wrote: > > >-- >Carlos Jacobo Puga Medina > > >> Enviar: lunes 12 de agosto de 2019 a las 15:52 >> De: "Alexey Dokuchaev" >> Para: "Carlos J=2E Puga Medina" >> CC: ports-committers@freebsd=2Eorg, svn-ports-all@freebsd=2Eorg, >svn-ports-head@freebsd=2Eorg >> Asunto: Re: svn commit: r508723 - head/net/ocserv >> >> On Mon, Aug 12, 2019 at 10:52:00AM +0000, Carlos J=2E Puga Medina >wrote: >> > New Revision: 508723 >> > URL: https://svnweb=2Efreebsd=2Eorg/changeset/ports/508723 >> > >> > Log: >> > net/ocserv: Fix typos in pkg-descr >> > >> > PR: 239577 >> > Submitted by: Mikael Urankar >> > >> > Modified: head/net/ocserv/pkg-descr >> > >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> > --- head/net/ocserv/pkg-descr Mon Aug 12 10:39:48 2019 (r508722) >> > +++ head/net/ocserv/pkg-descr Mon Aug 12 10:52:00 2019 (r508723) >> > @@ -6,9 +6,9 @@ The OpenConnect protocol provides a dual TCP/UDP >VPN c >> > uses the standard IETF security protocols to secure it=2E Both IPv4 >> > and IPv6 are supported=2E >> > >> > -Ocserv's main features are security through provilege separation >> > +Ocserv's main features are security through privilege separation >> > and sandboxing, accounting, and resilience due to a combined use >> > -of TCP and UDP=2E Authentication occurs in an isolated security >> > +of TCP and UDP=2E Authentication occurs in an isolated security >> >> This was not a typo, plain text generally looks better with double >> spaces after full stop; it might not be as popular in other places/ >> traditions as it is in US, but FreeBSD typically adheres to Americal >> spelling and formatting rules=2E >> >> Regardless of one's personal preference, touching the line merely to >> change the amount of whitespace between sentences is gratuitous (part >> of the) commmit and should've been avoided=2E >> > >Thanks for the explanation=2E In fact, if you strongly disagree, please >do not hesitate to revert the commit=2E > >> =2E/danfe >> >> Personally, I prefer to keep style and formatting changes separate from f= unctional changes=2E This is especially relevant for base but IMO also rele= vant for ports=2E Months or years from now when bisecting a revision, it is= easier to review only a functional change than to have to work through a c= hange polluted by gratuitous formatting changes=2E Consider the poor soul w= ho's trying to figure out what was done long after a commit=2E Either don't= reformat or reformat in a separate commit=2E Pet portlint separately too= =2E It also makes bisecting more time consuming=2E --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert FreeBSD UNIX: Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E