Date: Thu, 3 Sep 2009 15:57:41 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Mel Flynn <mel.flynn+fbsd.fs@mailing.thruhere.net> Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org Subject: Re: Patch to allow gmirror to set priority of a disk Message-ID: <20090903135741.GK1821@garage.freebsd.pl> In-Reply-To: <200909031548.37887.mel.flynn%2Bfbsd.fs@mailing.thruhere.net> References: <200909030000.11961.mel.flynn%2Bfbsd.fs@mailing.thruhere.net> <20090903124407.GJ1821@garage.freebsd.pl> <200909031548.37887.mel.flynn%2Bfbsd.fs@mailing.thruhere.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--yr6OvWOSyJed8q4v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 03, 2009 at 03:48:37PM +0200, Mel Flynn wrote: > On Thursday 03 September 2009 14:44:07 Pawel Jakub Dawidek wrote: > > I'd suggest doing this not as separate gmirror(8) subcommand, but as an > > extension to 'configure' subcommand, where one can provide priority by > > giving '-p' argument. >=20 > Except I didn't see how configure was implemented. Am I correct that this= is=20 > g_mirror_ctl_configure in sys/geom/mirror/g_mirror_ctl.c? Yes, you are correct. > On a related note, perhaps the attached can be applied so that there's no= =20 > question about the priority numbering? > --=20 > Mel > Index: sbin/geom/class/mirror/gmirror.8 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sbin/geom/class/mirror/gmirror.8 (revision 196776) > +++ sbin/geom/class/mirror/gmirror.8 (working copy) > @@ -115,8 +115,8 @@ > .It Cm label > Create a mirror. > The order of components is important, because a component's priority is = based on its position > -(starting from 0). > -The component with the biggest priority is used by the > +(starting from 0 to 255). > +The component with the biggest priority (the lowest number) is used by t= he > .Cm prefer > balance algorithm > and is also used as a master component when resynchronization is needed, Looks good. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --yr6OvWOSyJed8q4v Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKn8tVForvXbEpPzQRApcpAJ9rfHa7mNQ7hx64QgBGc+ZCkqwcyACg9H1e 20cxVc5Q9+M+jC9EVlG5mM4= =s1QF -----END PGP SIGNATURE----- --yr6OvWOSyJed8q4v--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090903135741.GK1821>