Date: Tue, 11 Oct 2005 20:01:48 +0200 (CEST) From: Erwin Lansing <erwin@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/87273: Add check for quotes around COMMENT to devel/portlint Message-ID: <200510111801.j9BI1mQu048872@bamse.staff.tdk.net> Resent-Message-ID: <200510111810.j9BIAEpt036929@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 87273
>Category: ports
>Synopsis: Add check for quotes around COMMENT to devel/portlint
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Oct 11 18:10:14 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Erwin Lansing
>Release: FreeBSD 4.11-STABLE i386
>Organization:
>Environment:
System: FreeBSD bamse.staff.tdk.net 4.11-STABLE FreeBSD 4.11-STABLE #11: Tue Aug 2 10:22:04 CEST 2005 root@bamse.staff.tdk.net:/usr/obj/usr/src/sys/BAMSE i386
>Description:
I just noticed that a new port submitted had a quoted "COMMENT" which
portlint didn't complain about. This patch adds a warning for this.
>How-To-Repeat:
>Fix:
--- portlint-quoted-comment.diff begins here ---
Index: portlint.pl
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.76
diff -u -r1.76 portlint.pl
--- portlint.pl 9 Oct 2005 18:52:58 -0000 1.76
+++ portlint.pl 11 Oct 2005 17:57:18 -0000
@@ -1198,6 +1198,16 @@
}
#
+ # whole file: COMMENT
+ #
+ print "OK: checking COMMENT.\n" if ($verbose);
+ if ($whole =~ /\nCOMMENT[+?]?=[ \t]+"/) {
+ my $lineno = &linenumber($`);
+ &perror("WARN: $file [$lineno]: COMMENT messages should not ".
+ "be quoted.");
+ }
+
+ #
# whole file: IGNORE
#
print "OK: checking IGNORE.\n" if ($verbose);
--- portlint-quoted-comment.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510111801.j9BI1mQu048872>