From owner-svn-ports-all@FreeBSD.ORG  Mon Jan 27 09:28:55 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 4DCB88EB; Mon, 27 Jan 2014 09:28:55 +0000 (UTC)
Date: Mon, 27 Jan 2014 09:28:55 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Baptiste Daroussin <bapt@FreeBSD.org>
Subject: Re: svn commit: r341341 - head/devel/xwpe
Message-ID: <20140127092855.GA88072@FreeBSD.org>
References: <201401270841.s0R8fjq3007225@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201401270841.s0R8fjq3007225@svn.freebsd.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jan 2014 09:28:55 -0000

On Mon, Jan 27, 2014 at 08:41:45AM +0000, Baptiste Daroussin wrote:
> New Revision: 341341
> URL: http://svnweb.freebsd.org/changeset/ports/341341
> QAT: https://qat.redports.org/buildarchive/r341341/
> 
> +CONFIGURE_ARGS=	--libdir=\$${STAGEDIR}${PREFIX}/share

Just a heads-up, not implying that you did not check it; but in many cases
it can be wrong: passing ${STAGEDIR} directly to configure script arguments
like this, there is a risk of ${STAGEDIR} getting embedded in the resulting
binaries, which is not what we want.

To verify if it's OK, one should grep the source code to see if there are
any references to STAGEDIR (DESTDIR) passed via -D... (preprocessor or in
the config.h), and finally, running something like "strings bin/* lib/* |
grep stage" to verify that ${STAGEDIR} does not remain in what would get
installed on users' systems.

In general, every time you see the need to pass --libdir=\$${STAGEDIR} or
even PREFIX=${STAGEDIR}${PREFIX} is an indication that ported software is
not quite DESTDIR-ready, and should be checked more thoroughly.

./danfe