Date: Tue, 11 Jul 2017 22:05:10 +0200 From: Marius Strobl <marius@freebsd.org> To: Vincenzo Maffione <v.maffione@gmail.com> Cc: FreeBSD Net <freebsd-net@freebsd.org> Subject: Re: NULL pointer dereference bug triggered by netmap Message-ID: <20170711200510.GB60651@alchemy.franken.de> In-Reply-To: <CA%2B_eA9h138BhHaeyEojzM3UFc__GWxV72uVSHCWVWw-6CbnGsw@mail.gmail.com> References: <CA%2B_eA9goJ6j=q6UO-%2BfOt-aHVgFmujQfH8WfYEHf9=PQobdwHg@mail.gmail.com> <20170705110512.GA28058@alchemy.franken.de> <CA%2B_eA9h138BhHaeyEojzM3UFc__GWxV72uVSHCWVWw-6CbnGsw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 06, 2017 at 02:19:42PM -0700, Vincenzo Maffione wrote: > Sure, can anyone commit this? The addition of KASSERTs like the below one to if_handoff() and if_start()? Sure. Marius > > Il 5 lug 2017 4:05 AM, "Marius Strobl" <marius@freebsd.org> ha scritto: > > > On Mon, Jul 03, 2017 at 05:08:09PM +0200, Vincenzo Maffione wrote: > > > Details here: > > > > > > https://github.com/luigirizzo/netmap/issues/322 > > > > > > Is it acceptable to commit the proposed patch? > > > > As suggested by hselasky@, the outliner problem at hand is better solved > > by a dummy if_start method in order to not hurt the fast-path. Thus, if > > anything at all, a KASSERT(ifp->if_start != NULL, "no if_start method") > > should be added to if_handoff() and if_start(). > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170711200510.GB60651>