From owner-p4-projects@FreeBSD.ORG  Fri Jun  1 22:15:26 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E3FFD16A469; Fri,  1 Jun 2007 22:15:25 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9DE4916A421
	for <perforce@freebsd.org>; Fri,  1 Jun 2007 22:15:25 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 8F79F13C447
	for <perforce@freebsd.org>; Fri,  1 Jun 2007 22:15:25 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l51MFPhn071219
	for <perforce@freebsd.org>; Fri, 1 Jun 2007 22:15:25 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l51MFPoK071209
	for perforce@freebsd.org; Fri, 1 Jun 2007 22:15:25 GMT
	(envelope-from piso@freebsd.org)
Date: Fri, 1 Jun 2007 22:15:25 GMT
Message-Id: <200706012215.l51MFPoK071209@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 120737 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jun 2007 22:15:26 -0000

http://perforce.freebsd.org/chv.cgi?CH=120737

Change 120737 by piso@piso_newluxor on 2007/06/01 22:14:38

	-correctly schedule the ithread in case there's no filter and mask
	the src in the meantime
	-correctly clear the interrupt src after the filter or th ithread ran 

Affected files ...

.. //depot/projects/soc2006/intr_filter/sparc64/sbus/sbus.c#13 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/sparc64/sbus/sbus.c#13 (text+ko) ====

@@ -635,11 +635,11 @@
 	int res;
 
 	scl = (struct sbus_clr *)arg;
-	if (scl->scl_handler != NULL)
+	if (scl->scl_handler != NULL) {
 		res = scl->scl_filter(scl->scl_arg);
-	else 
-		res = FILTER_HANDLED | FILTER_SCHEDULE_THREAD;
-	SYSIO_WRITE8(scl->scl_sc, scl->scl_clr, 0);
+		SYSIO_WRITE8(scl->scl_sc, scl->scl_clr, 0);
+	} else 
+		res = FILTER_SCHEDULE_THREAD;	
 	return (res);
 }
 
@@ -650,6 +650,8 @@
 
 	scl = (struct sbus_clr *)arg;
 	scl->scl_handler(scl->scl_arg);
+	if (scl->scl_handler == NULL)
+		SYSIO_WRITE8(scl->scl_sc, scl->scl_clr, 0);
 }
 
 static int