From nobody Fri Oct 11 15:35:26 2024 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XQ9gP12R4z5Z2mq for ; Fri, 11 Oct 2024 15:35:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XQ9gN5m6lz4sgC; Fri, 11 Oct 2024 15:35:28 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id zCx5sE3agAHbZzHfss8yhs; Fri, 11 Oct 2024 15:35:28 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id zHfqsRk8GE0IVzHfrsnnDE; Fri, 11 Oct 2024 15:35:28 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=cI9DsUeN c=1 sm=1 tr=0 ts=670945c0 a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=DAUX931o1VcA:10 a=pGLkceISAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=V7zmBP6tqZOSsE1Ang8A:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 69C37EF; Fri, 11 Oct 2024 08:35:26 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 431EA110; Fri, 11 Oct 2024 08:35:26 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Enji Cooper cc: Cy Schubert , Mark Johnston , "David E. Cross" , FreeBSD Hackers Subject: Re: Review D38047 ... and then there was one.... In-reply-to: References: <20241007150830.939DC334@slippy.cwsent.com> Comments: In-reply-to Enji Cooper message dated "Fri, 11 Oct 2024 08:25:02 -0700." List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 11 Oct 2024 08:35:26 -0700 Message-Id: <20241011153526.431EA110@slippy.cwsent.com> X-CMAE-Envelope: MS4xfLF3v3N57fWUy4HZL+5BfHe3uaO5Np7mQLYBsTVHqndQinyqBz6GuvU8wSsHhqHzMRP58TSTgXNkEm/RutvVAHnE+G1WO8Nb4/0W0EQu36i/LxgGWBij kRriZW43T0nPy9ZAQ6IP/Map3MGw8gRCDf926rZ3ug/OKHNYh0rtYGKmAVINC/RbwZNL0SPC/QFZ1qB/tHwyVuL32h7+1QuvyI7+nooQ8fWRvCqr+VncxktU bvXwbb2Oq9eSJMTopQ5YjijHH2GeQKpFtvGUlJEJ6n+3mWK+tUNT4vHDZh4gjW78VgymCiZPTRaCtsE3RmhzdA== X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4XQ9gN5m6lz4sgC X-Spamd-Bar: ---- In message , Enji Cooper writes : > > > > On Oct 7, 2024, at 08:08, Cy Schubert wrote: > > > Yes. I was about to suggest this. Plus, any proposed commit log message > > must answer the questions why, what and how. With special attention to why= > . > > I have the same feelings as Cy. > > FWIW, part of the reason why large/complex changes like this languish in my r > = > eview queues is in part due to reasons like this. Totally! > > Unless I am a SME in the area who is driven to understand what the change ai= > ms to achieve, I will not take the time to review large/complex chances. I h= > ave a lot of other things in my life which take priority over large code rev= > iews. Agreed. In the case of nscd, I applied one fix to it years ago. Like you, I do not feel qualified to review a large and complex jumbo patch (group of patches). > > Please break the large change down into a smaller set of changes/reviews to m > = > ake it easier to review the overall change effectively. Yes. I have the same issue at $JOB. We use github enterprise. I refuse to review such patches and yet others, less experienced, summarily approve such patches without even looking at them, breaking our infrastructure. The choice is clear. > > Cheers, > -Enji= -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0