From owner-freebsd-wireless@FreeBSD.ORG Sat Jan 21 00:38:55 2012 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 937CB1065673; Sat, 21 Jan 2012 00:38:55 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id 29F218FC1C; Sat, 21 Jan 2012 00:38:54 +0000 (UTC) Received: by vbbey12 with SMTP id ey12so1229437vbb.13 for ; Fri, 20 Jan 2012 16:38:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=dZWoxGoZwpaYoCAo3Z9M80ysHSSEgJFAGQ99PjMaqR8=; b=UNfMphTBm9IoGRl/K/+70Vmeju7P8GKfRqCACzdM6gLdnrb/4ph4I1JUrPwh5SHZZ8 D9TYEboYtz/G5tENehKpAGRPpCo1KOBBwNpDytgY6rvCSq8+HOYcy40b98zMVFd5fl+1 GYzxehNqJbUZRbBOxClDb2DJ54auCnJfxRAto= MIME-Version: 1.0 Received: by 10.52.30.81 with SMTP id q17mr5879029vdh.115.1327106334322; Fri, 20 Jan 2012 16:38:54 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.36.5 with HTTP; Fri, 20 Jan 2012 16:38:54 -0800 (PST) In-Reply-To: References: <201201112003.44891.bschmidt@freebsd.org> Date: Fri, 20 Jan 2012 16:38:54 -0800 X-Google-Sender-Auth: L9u4fRXNxLUZ4A0PNX1fTxss9G4 Message-ID: From: Adrian Chadd To: Monthadar Al Jaberi Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-wireless@freebsd.org, Bernhard Schmidt Subject: Re: 11s mesh path setup problem X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2012 00:38:55 -0000 Committed in r230408. Thanks! adrian On 16 January 2012 11:46, Monthadar Al Jaberi wrote: > On Mon, Jan 16, 2012 at 9:39 AM, Monthadar Al Jaberi > wrote: > > On Wed, Jan 11, 2012 at 8:03 PM, Bernhard Schmidt > wrote: > >> On Wednesday 11 January 2012 18:23:29 Adrian Chadd wrote: > >>> Hi! > >>> > >>> I've just done a bit of a code review. Here are my comments: > > > > sorry for late answer here is a a better formated patch. > > > >>> > >>> * ether_sprintf() can't be implemented the way you've implemented it - > >>> it just won't work at all in a multithreaded, concurrent environment. > >>> We'll have to find an alternative way. > >>> > >>> Maybe something like: > >>> > >>> char * > >>> ether_sprintf2(const u_char *ap, char *buf, int len) > >>> { > >>> .. do things to buf, rather than the static buf. > >>> } > >>> > >>> Then maybe this'd work: > >>> > >>> char a[32], b[32]; > >>> IEEE80211_NOTE(..., ether_sprintf2(addr1, a, 32), > ether_sprintf2(addr2, a, 32)); > >>> > >>> does that make sense? > >> > >> Isn't there an example in net80211 with %D? > >> printf("%6D %6D", addr1, ":", addr2, ":"); > > Ok here is a patch just for fixing ieee80211_hwmp IEEE80211_NOTE > function calls before my patch. > does it look okej? > > >> > >> The saner alternative is to call printf() multiple times, see > ieee80211_dump_pkt() as an example. > > > > But that means we have to modify for example ieee80211_note_mac function? > > > >> > >> -- > >> Bernhard > > > > > > > > -- > > Monthadar Al Jaberi > > > > -- > Monthadar Al Jaberi >