From owner-p4-projects@FreeBSD.ORG Wed Aug 2 15:03:15 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id F23BE16A4DD; Wed, 2 Aug 2006 15:03:14 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0A6816A4E1 for ; Wed, 2 Aug 2006 15:03:14 +0000 (UTC) (envelope-from piso@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1713343D6B for ; Wed, 2 Aug 2006 15:03:14 +0000 (GMT) (envelope-from piso@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k72F3Dg0063864 for ; Wed, 2 Aug 2006 15:03:13 GMT (envelope-from piso@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k72F3D6d063861 for perforce@freebsd.org; Wed, 2 Aug 2006 15:03:13 GMT (envelope-from piso@freebsd.org) Date: Wed, 2 Aug 2006 15:03:13 GMT Message-Id: <200608021503.k72F3D6d063861@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to piso@freebsd.org using -f From: Paolo Pisati To: Perforce Change Reviews Cc: Subject: PERFORCE change 103026 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 15:03:15 -0000 http://perforce.freebsd.org/chv.cgi?CH=103026 Change 103026 by piso@piso_newluxor on 2006/08/02 15:02:52 After a brief talk with scottl about aac, he convinced me that the mask/unmask isn't the ideal approach here. Affected files ... .. //depot/projects/soc2006/intr_filter/dev/aac/aac.c#7 edit Differences ... ==== //depot/projects/soc2006/intr_filter/dev/aac/aac.c#7 (text+ko) ==== @@ -814,8 +814,6 @@ */ wakeup(sc->aifthread); } - if (ret & FILTER_SCHEDULE_THREAD) - AAC_MASK_INTERRUPTS(sc); return((ret)?ret:FILTER_STRAY); } @@ -1079,7 +1077,6 @@ aac_startio(sc); mtx_unlock(&sc->aac_io_lock); - AAC_UNMASK_INTERRUPTS(sc); } /*