Date: Mon, 27 Jan 2014 09:28:55 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r341341 - head/devel/xwpe Message-ID: <20140127092855.GA88072@FreeBSD.org> In-Reply-To: <201401270841.s0R8fjq3007225@svn.freebsd.org> References: <201401270841.s0R8fjq3007225@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 27, 2014 at 08:41:45AM +0000, Baptiste Daroussin wrote: > New Revision: 341341 > URL: http://svnweb.freebsd.org/changeset/ports/341341 > QAT: https://qat.redports.org/buildarchive/r341341/ > > +CONFIGURE_ARGS= --libdir=\$${STAGEDIR}${PREFIX}/share Just a heads-up, not implying that you did not check it; but in many cases it can be wrong: passing ${STAGEDIR} directly to configure script arguments like this, there is a risk of ${STAGEDIR} getting embedded in the resulting binaries, which is not what we want. To verify if it's OK, one should grep the source code to see if there are any references to STAGEDIR (DESTDIR) passed via -D... (preprocessor or in the config.h), and finally, running something like "strings bin/* lib/* | grep stage" to verify that ${STAGEDIR} does not remain in what would get installed on users' systems. In general, every time you see the need to pass --libdir=\$${STAGEDIR} or even PREFIX=${STAGEDIR}${PREFIX} is an indication that ported software is not quite DESTDIR-ready, and should be checked more thoroughly. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140127092855.GA88072>