Date: Wed, 17 Oct 2012 19:28:41 -0400 From: Ryan Steinmetz <zi@freebsd.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r305809 - head/security/snort Message-ID: <20121017232841.GA46258@exodus.zi0r.com> In-Reply-To: <CAMHz58RcKf5bfbR8u2vCT86REo9rEGE3SGsAQ_KN1nvpKYJCfQ@mail.gmail.com> References: <201210130205.q9D25ECl018941@svn.freebsd.org> <CAMHz58RcKf5bfbR8u2vCT86REo9rEGE3SGsAQ_KN1nvpKYJCfQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On (10/18/12 01:57), Sunpoet Po-Chuan Hsieh wrote: > On Sat, Oct 13, 2012 at 10:05 AM, Ryan Steinmetz <zi@freebsd.org> wrote: > > Author: zi > > Date: Sat Oct 13 02:05:14 2012 > > New Revision: 305809 > > URL: http://svn.freebsd.org/changeset/ports/305809 > > > > Log: > > - As pulledpork/barnyard are required for most installations, depend on these by default > > > > Feature safe: yes > > > > Modified: > > head/security/snort/Makefile > > > > Modified: head/security/snort/Makefile > > ============================================================================== > > --- head/security/snort/Makefile Sat Oct 13 01:42:15 2012 (r305808) > > +++ head/security/snort/Makefile Sat Oct 13 02:05:14 2012 (r305809) > > @@ -27,9 +27,10 @@ RUN_DEPENDS= daq>=1.1.1:${PORTSDIR}/net/ > > > > OPTIONS_DEFINE= IPV6 MPLS GRE TARGETBASED ZLIB NORMALIZER REACT \ > > PERFPROFILE FLEXRESP3 LRGPCAP SNORTSAM SOURCEFIRE \ > > - DBGSNORT > > + DBGSNORT BARNYARD PULLEDPORK > > OPTIONS_DEFAULT=IPV6 MPLS GRE ZLIB NORMALIZER REACT PERFPROFILE \ > > - FLEXRESP3 SOURCEFIRE TARGETBASED > > + FLEXRESP3 SOURCEFIRE TARGETBASED PULLEDPORK \ > > + BARNYARD > > > > GRE_DESC= Enable GRE support > > TARGETBASED_DESC= Enable targetbased support > > @@ -42,6 +43,8 @@ LRGPCAP_DESC= Enable pcaps larger than > > SNORTSAM_DESC= Enable unofficial Snortsam patch > > SOURCEFIRE_DESC= Enable Sourcefire-specific build options > > DBGSNORT_DESC= Enable debugging symbols+core dumps > > +BARNYARD_DESC= Depend on Barnyard2 > > +PULLEDPORK_DESC= Depend on pulledpork > > > > .include <bsd.port.options.mk> > > > > @@ -142,6 +145,14 @@ PATCH_SITES+= http://www.snortsam.net/fi > > PATCHFILES+= snortsam-2.9.2.2.diff.gz:snortsam > > .endif > > > > +.if ${PORT_OPTIONS:MBARNYARD} > > +RUN_DEPENDS+= barnyard2:${PORTSDIR}/security/barnyard2 > > +.endif > > + > > +.if ${PORT_OPTIONS:MPULLEDPORK} > > +RUN_DEPENDS+= pulledpork.pl:${PORTSDIR}/security/pulledpork > > +.endif > > + > > post-patch: > > @${FIND} ${WRKSRC} -name 'Makefile.in' | ${XARGS} ${REINPLACE_CMD} -e 's|lib/snort_|lib/snort/|g' > > @${REINPLACE_CMD} "s,/etc/snort.conf,${CONFIG_DIR}/snort.conf," ${WRKSRC}/src/snort.c ${WRKSRC}/snort.8 > > Hi Ryan, > > FYI, PORTREVISION bump is required since RUN_DEPENDS has been changed > (barnyard2 and pulledpork are added by default). An update to 2.4.0 will be released shortly, so I will wait to make people rebuild stuff until then. There's no real need to force them to rebuild stuff at this point in time. Users who are using snort will likely already have pulledpork/barnyard2 installed. > > OTOH, barnyard2 has options to add snort to RUN_DEPENDS, it might > become cyclic depnedency. IMHO, barnyard2 and pulledpork work like > add-ons or management tools of snort.It would be better not to add > them to snort's dependencies. I suggest to revert this commit. > Thanks. I can ping the maintainer of pulledpork/barnyard2 and have them remove the depends on snort. There's no reason to install them if you don't have snort installed, so it makes more sense to have snort depend on them. A user would first goto install snort on a system, not the other way around. > > Regards, > sunpoet -- Ryan Steinmetz PGP: EF36 D45A 5CA9 28B1 A550 18CD A43C D111 7AD7 FAF2
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121017232841.GA46258>