From nobody Wed Jul 16 21:30:36 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bj8Ns35L7z6222Z; Wed, 16 Jul 2025 21:30:37 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bj8Nr6RKHz4F0w; Wed, 16 Jul 2025 21:30:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752701436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6GRwFqRyseiy0BoZaMJ6enfHGZfELnANteDFf+QU6A4=; b=xbGUioVRypSAuMUqCoFwuqkhUYoL/gbcgRfYq7w4PiEm6UR9ruQOBpizORKDkfugUIhYnt OalxE4G09q71/kvObCKu3ZZZgF3SA2kcrBCWV5denFzRYwYWqzIx0nKw7aWnRSTTY8y9OE ZOU+BWl+NZY/oHHcYkVqmo/8jCRf8minOhmf/0uhUoZSlpP1nX5rzfb6zqu02pi15AfADq Mw0SKv6JsUz0WwU99yYFehbz49ormPCRCAFzK8CjLcuQxl8Rs68eLdSR1L9Bz2hbQIfvqJ IFXipL8yR27wsO/ixLxA8cx8aBREgSd4rObyCt2oaouJuZeYvd7ydwZaRafjug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752701436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6GRwFqRyseiy0BoZaMJ6enfHGZfELnANteDFf+QU6A4=; b=E1HCbNWIg79++7ISFepbeuS953sTB0qmsiwfL6DXNCZmvsDMl/mJQ2XCQSySTGLksXPu66 r5eKlmqA71ZYkxrFGW4/5smCFO4jG2z7zyRnVsNq+SnOH7xhgIA99FsPxnLvwAFudBxYs7 DXRbfr+2vdO+GsaharCfGuwAWPQBVaO9O6OIf6qfv1ksteGYpF4HIcwtOSwFYO9zIWMBJO 6vKogDTd3EGApKOAYaHLKy5RjsTvDAySE59hlqLaYdTReKr2qk0SaCkyh/051sxAIdtbGT fTgbj2j0a5bBSi7DAjQ384hE8aqhZWnXF4rxqASnXiStoTDSxTXCQZuzdDiBzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752701436; a=rsa-sha256; cv=none; b=DqPmwE+skFXLD0oNdlekzV+fnq9oz1Fv51nDngDkBaMs4CB5uVBS5Ywh0VQVjpgsxvkwlz OunlnEE4RU39tvRS5khmWVfOxAd2RQhRoaZR+Pxrm8dUoA6luwB2FGMWzyC7Bo0xPT9PMl eUXOcPV99M/XOOF9RLYpiIopy+kFam2qSHbTEWrhD7T+BUBOvT4DHCkJaZ3/5I7wKLxS66 aH2jdqdN++RuN0fBUep9dx58AIx/moGRNkkJ9NlpzVY40vUMqDp/Agq9K4ZyeyOhOisVKY 4b+jtrTY3LtCWNEzDeWHQd8vjJmVsGJQkOLVa0I5uhkcmzNnJsjELEAbQsU52w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bj8Nr610fzBV7; Wed, 16 Jul 2025 21:30:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56GLUaJ5034733; Wed, 16 Jul 2025 21:30:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56GLUaI5034730; Wed, 16 Jul 2025 21:30:36 GMT (envelope-from git) Date: Wed, 16 Jul 2025 21:30:36 GMT Message-Id: <202507162130.56GLUaI5034730@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 5f9a73c22fea - main - mgb: Fix mac tx disable bug in teardown List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5f9a73c22fea8973e047477853529feaedea6fe6 Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=5f9a73c22fea8973e047477853529feaedea6fe6 commit 5f9a73c22fea8973e047477853529feaedea6fe6 Author: jefby AuthorDate: 2025-07-05 02:52:08 +0000 Commit: Ed Maste CommitDate: 2025-07-16 21:30:06 +0000 mgb: Fix mac tx disable bug in teardown Signed-off-by: jefby Reviewed-by: emaste Pull-request: https://github.com/freebsd/freebsd-src/pull/1755 --- sys/dev/mgb/if_mgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/mgb/if_mgb.c b/sys/dev/mgb/if_mgb.c index 1240d0f84415..409f34167df0 100644 --- a/sys/dev/mgb/if_mgb.c +++ b/sys/dev/mgb/if_mgb.c @@ -1435,7 +1435,7 @@ mgb_hw_teardown(struct mgb_softc *sc) /* Stop MAC */ CSR_CLEAR_REG(sc, MGB_MAC_RX, MGB_MAC_ENBL); - CSR_WRITE_REG(sc, MGB_MAC_TX, MGB_MAC_ENBL); + CSR_CLEAR_REG(sc, MGB_MAC_TX, MGB_MAC_ENBL); if ((err = mgb_wait_for_bits(sc, MGB_MAC_RX, MGB_MAC_DSBL, 0))) return (err); if ((err = mgb_wait_for_bits(sc, MGB_MAC_TX, MGB_MAC_DSBL, 0)))