From owner-svn-ports-head@FreeBSD.ORG  Tue Jul 17 23:07:41 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 0154E106566B;
	Tue, 17 Jul 2012 23:07:41 +0000 (UTC)
	(envelope-from kozlov@ravenloft.kiev.ua)
Received: from ravenloft.kiev.ua (ravenloft.kiev.ua [94.244.131.95])
	by mx1.freebsd.org (Postfix) with ESMTP id B23658FC08;
	Tue, 17 Jul 2012 23:07:40 +0000 (UTC)
Date: Wed, 18 Jul 2012 02:07:39 +0300
From: Alex Kozlov <spam@rm-rf.kiev.ua>
To: Niclas Zeising <zeising@freebsd.org>, Doug Barton <dougb@dougbarton.us>
Message-ID: <20120717230739.GA66332@ravenloft.kiev.ua>
References: <201207172057.q6HKvEJc094784@svn.freebsd.org>
	<5005DB51.7050809@dougbarton.us> <5005E5C4.2030809@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5005E5C4.2030809@freebsd.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
	ports-committers@freebsd.org
Subject: Re: svn commit: r301039 - head/archivers/zlib
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the ports tree for head
	<svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>, 
	<mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
	<mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jul 2012 23:07:41 -0000

On Wed, Jul 18, 2012 at 12:23:00AM +0200, Niclas Zeising wrote:
> On 07/17/12 23:38, Doug Barton wrote:
> > Was this causing you some sort of specific problem? AFAIK this happens
> > often, possibly as a result of 'make makesum'. "Fixing" this everyplace
> > that it occurs would almost certainly cause a lot of needless churn.
Actually, it's pretty rare occurrence, so it does not add much churn.
Also while harmless, this is still an error, like unused variable or typo.
I agree that ideally this type of change should be committed with
other changes, but it's hard to achieve because usually successive commits
are made by different committers. 
Would be even better to find out why it happens at all, but i've done
thousands of tests and still can't reproduce it with make makesum. 

> I was asked by ak@ to fix it in this specific instance.  I forgot to 
> mention that in the commit message, unfortunately.
It's not necessary.


-- 
Alex