Date: Fri, 12 Aug 2022 09:51:40 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 4c8ea3efe73c - main - stand: Go back to a.out format for /boot/loader Message-ID: <9d8000f5-029d-033e-5b81-ae71951fa2f6@FreeBSD.org> In-Reply-To: <202208112330.27BNU0nN026141@gitrepo.freebsd.org> References: <202208112330.27BNU0nN026141@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/11/22 4:30 PM, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4c8ea3efe73c12d595472a7fc37177432a77858e > > commit 4c8ea3efe73c12d595472a7fc37177432a77858e > Author: Warner Losh <imp@FreeBSD.org> > AuthorDate: 2022-08-11 23:29:10 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2022-08-11 23:29:10 +0000 > > stand: Go back to a.out format for /boot/loader > > Turns out there's two hidden a.out dependencies. pxeldr.S assumes it has > access to the a.out header from /boot/loader and cdboot.S assumes that > /boot/loader is also a.out and doesn't use boot2. > > So, go back to making a.out files for these and adjust the size checks > to use ls, but we only need to check loader.bin. Trim the size we check > against by 2,000. The difference in size between loader and loader.bin > is about 3000 bytes, but clang15 produces binaries that are a smidge > bigger so we need to relax the check just a little and accept some > additional risk for the moment. > > Add some comments to loader's Makefile about this. > > Sponsored by: Netflix > Reviewed by: emaste > Differential Revision: https://reviews.freebsd.org/D36142 Thanks! -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9d8000f5-029d-033e-5b81-ae71951fa2f6>