From owner-freebsd-current@FreeBSD.ORG Sat Aug 20 09:28:21 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1599516A41F for ; Sat, 20 Aug 2005 09:28:21 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from haven.freebsd.dk (haven.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id B1CB643D48 for ; Sat, 20 Aug 2005 09:28:20 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (unknown [192.168.48.2]) by haven.freebsd.dk (Postfix) with ESMTP id BC736BC66; Sat, 20 Aug 2005 09:28:16 +0000 (UTC) To: Huang wen hui From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 18 Aug 2005 19:54:31 +0800." <430476F7.6030007@gddsn.org.cn> Date: Sat, 20 Aug 2005 11:28:15 +0200 Message-ID: <40238.1124530095@phk.freebsd.dk> Sender: phk@phk.freebsd.dk Cc: current@freebsd.org Subject: Re: suspend/resume operation broken with usb mouse X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Aug 2005 09:28:21 -0000 In message <430476F7.6030007@gddsn.org.cn>, Huang wen hui writes: >hi, >Using today's CURRENT, my TP42P could not resume with usb mouse. >cause "double fault" panic. With internal TrackPoint is OK, >The DDB backtrace message can be found: Can you try this patch ? Index: kern/kern_conf.c =================================================================== RCS file: /home/ncvs/src/sys/kern/kern_conf.c,v retrieving revision 1.190 diff -u -r1.190 kern_conf.c --- kern/kern_conf.c 17 Aug 2005 08:19:52 -0000 1.190 +++ kern/kern_conf.c 20 Aug 2005 09:24:35 -0000 @@ -443,10 +443,14 @@ static void fini_cdevsw(struct cdevsw *devsw) { + struct cdevsw *gt; - if (devsw->d_gianttrick != NULL) - free(devsw->d_gianttrick, M_DEVT); - devsw->d_gianttrick = NULL; + if (devsw->d_gianttrick != NULL) { + gt = devsw->d_gianttrick; + memcpy(devsw, gt, sizeof *devsw); + free(gt, M_DEVT); + devsw->d_gianttrick = NULL; + } devsw->d_flags &= ~D_INIT; } -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.