From owner-svn-src-head@FreeBSD.ORG  Fri Mar  9 18:34:15 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 376F91065670;
	Fri,  9 Mar 2012 18:34:15 +0000 (UTC)
	(envelope-from trasz@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 21ECA8FC1A;
	Fri,  9 Mar 2012 18:34:15 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q29IYEZj019713;
	Fri, 9 Mar 2012 18:34:14 GMT (envelope-from trasz@svn.freebsd.org)
Received: (from trasz@localhost)
	by svn.freebsd.org (8.14.4/8.14.4/Submit) id q29IYEoc019711;
	Fri, 9 Mar 2012 18:34:14 GMT (envelope-from trasz@svn.freebsd.org)
Message-Id: <201203091834.q29IYEoc019711@svn.freebsd.org>
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
Date: Fri, 9 Mar 2012 18:34:14 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r232738 - head/usr.sbin/diskinfo
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Mar 2012 18:34:15 -0000

Author: trasz
Date: Fri Mar  9 18:34:14 2012
New Revision: 232738
URL: http://svn.freebsd.org/changeset/base/232738

Log:
  Improve error reporting in diskinfo(8) by not displaying errno when
  it doesn't make sense.

Modified:
  head/usr.sbin/diskinfo/diskinfo.c

Modified: head/usr.sbin/diskinfo/diskinfo.c
==============================================================================
--- head/usr.sbin/diskinfo/diskinfo.c	Fri Mar  9 18:26:35 2012	(r232737)
+++ head/usr.sbin/diskinfo/diskinfo.c	Fri Mar  9 18:34:14 2012	(r232738)
@@ -99,13 +99,13 @@ main(int argc, char **argv)
 		}
 		error = ioctl(fd, DIOCGMEDIASIZE, &mediasize);
 		if (error) {
-			warn("%s: ioctl(DIOCGMEDIASIZE) failed, probably not a disk.", argv[i]);
+			warnx("%s: ioctl(DIOCGMEDIASIZE) failed, probably not a disk.", argv[i]);
 			exitval = 1;
 			goto out;
 		}
 		error = ioctl(fd, DIOCGSECTORSIZE, &sectorsize);
 		if (error) {
-			warn("%s: DIOCGSECTORSIZE failed, probably not a disk.", argv[i]);
+			warnx("%s: ioctl(DIOCGSECTORSIZE) failed, probably not a disk.", argv[i]);
 			exitval = 1;
 			goto out;
 		}
@@ -178,8 +178,10 @@ rdsect(int fd, off_t blockno, u_int sect
 
 	lseek(fd, (off_t)blockno * sectorsize, SEEK_SET);
 	error = read(fd, sector, sectorsize);
+	if (error == -1)
+		err(1, "read");
 	if (error != (int)sectorsize)
-		err(1, "read error or disk too small for test.");
+		errx(1, "disk too small for test.");
 }
 
 static void
@@ -188,8 +190,10 @@ rdmega(int fd)
 	int error;
 
 	error = read(fd, mega, sizeof(mega));
+	if (error == -1)
+		err(1, "read");
 	if (error != sizeof(mega))
-		err(1, "read error or disk too small for test.");
+		errx(1, "disk too small for test.");
 }
 
 static struct timeval tv1, tv2;